mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Grzegorz Andrejczuk <grzegorz.andrejczuk@intel.com>
Cc: mingo@redhat.com, hpa@zytor.com, x86@kernel.org, bp@suse.de,
	dave.hansen@linux.intel.com, linux-kernel@vger.kernel.org,
	lukasz.daniluk@intel.com, james.h.cownie@intel.com,
	jacob.jun.pan@intel.com
Subject: Re: [PATCH v4 2/4] x86/phi: Add enabling of the R3MWAIT during boot
Date: Thu, 20 Oct 2016 21:10:00 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1610202105000.4938@nanos> (raw)
In-Reply-To: <1476784971-23872-3-git-send-email-grzegorz.andrejczuk@intel.com>

On Tue, 18 Oct 2016, Grzegorz Andrejczuk wrote:
> +static void probe_xeon_phi_r3mwait(struct cpuinfo_x86 *c)
> +{
> +	if (phi_r3mwait_disabled)
> +		return;

So you return when the command line option to disable the feature was
given. That's not really a good choice if the feature is already enabled
due to BIOS featuritis. This can also happen when you kexec from a enabled
kernel into one which has the command line option set.

You really should make sure that the command line option results in
disabling the feature no matter what.

Thanks,

	tglx

  reply	other threads:[~2016-10-20 19:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-18 10:02 [PATCH v4 0/4] Enabling Ring 3 MONITOR/MWAIT feature for Knights Landing Grzegorz Andrejczuk
2016-10-18 10:02 ` [PATCH v4 1/4] x86/phi: Add R3MWAIT register and bit to msr-info.h Grzegorz Andrejczuk
2016-10-18 10:02 ` [PATCH v4 2/4] x86/phi: Add enabling of the R3MWAIT during boot Grzegorz Andrejczuk
2016-10-20 19:10   ` Thomas Gleixner [this message]
2016-10-18 10:02 ` [PATCH v4 3/4] x86: Use HWCAP2 to expoose Xeon Phi ring 3 MWAIT Grzegorz Andrejczuk
2016-10-20 19:11   ` Thomas Gleixner
2016-10-18 10:02 ` [PATCH v4 4/4] x86/phi: Add R3MWAIT to CPU features Grzegorz Andrejczuk
2016-10-20 19:12   ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1610202105000.4938@nanos \
    --to=tglx@linutronix.de \
    --cc=bp@suse.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=grzegorz.andrejczuk@intel.com \
    --cc=hpa@zytor.com \
    --cc=jacob.jun.pan@intel.com \
    --cc=james.h.cownie@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukasz.daniluk@intel.com \
    --cc=mingo@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®