From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756093AbcJVUlj (ORCPT ); Sat, 22 Oct 2016 16:41:39 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:33523 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751816AbcJVUlg (ORCPT ); Sat, 22 Oct 2016 16:41:36 -0400 X-IronPort-AV: E=Sophos;i="5.31,532,1473112800"; d="scan'208";a="241952319" Date: Sat, 22 Oct 2016 22:41:32 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Tomas Novotny cc: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Yong Li , Akinobu Mita , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kbuild-all@01.org Subject: [PATCH] iio: dac: mcp4725: fix odd_ptr_err.cocci warnings Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org PTR_ERR should access the value just tested by IS_ERR Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci CC: Tomas Novotny Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu --- Please take the patch only if it's a positive warning. Thanks! Not checked at all. This is being reported on the following tree: tree: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git testing head: 2796a310d462f73954c0ce8ffabaf4baacaecca1 commit: e0b80def1faa901d83a7d580e8aa4ad4a512bedf [109/113] iio: dac: mcp4725: support voltage reference selection :::::: branch date: 2 hours ago :::::: commit date: 2 hours ago mcp4725.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/iio/dac/mcp4725.c +++ b/drivers/iio/dac/mcp4725.c @@ -418,7 +418,7 @@ static int mcp4725_probe(struct i2c_clie if (pdata->use_vref) { data->vref_reg = devm_regulator_get(&client->dev, "vref"); if (IS_ERR(data->vref_reg)) { - err = PTR_ERR(data->vdd_reg); + err = PTR_ERR(data->vref_reg); goto err_disable_vdd_reg; }