From: Thomas Gleixner <tglx@linutronix.de>
To: Borislav Petkov <bp@alien8.de>
Cc: "He Chen" <he.chen@linux.intel.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Ingo Molnar" <mingo@redhat.com>,
"H . Peter Anvin" <hpa@zytor.com>,
"Luwei Kang" <luwei.kang@intel.com>,
"Piotr Luc" <Piotr.Luc@intel.com>
Subject: Re: [PATCH v4 1/2] cpuid: Add a helper in scattered.c to return cpuid leaf info
Date: Tue, 8 Nov 2016 16:11:36 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1611081606310.3501@nanos> (raw)
In-Reply-To: <20161108103008.drrg2dovlxkvs7du@pd.tnic>
On Tue, 8 Nov 2016, Borislav Petkov wrote:
> On Tue, Nov 08, 2016 at 04:52:27PM +0800, He Chen wrote:
> > +struct cpuid_regs {
> > + u32 eax, ebx, ecx, edx;
> > +};
>
> Why do you export this? It is used in cpuid.c only.
Because I asked for it. We should have this stuff in one place to avoid the
next name clash.
What's worse with that patch is, that it does two things in one go:
- cleanup that whole cpuid_regs mess
- add the new function
That should clearly be seperated into two patches.
Thanks,
tglx
next prev parent reply other threads:[~2016-11-08 15:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 8:52 [PATCH v4 0/2] cpuid: Support AVX512_4VNNIW and AVX512_4FMAPS for KVM guest He Chen
2016-11-08 8:52 ` [PATCH v4 1/2] cpuid: Add a helper in scattered.c to return cpuid leaf info He Chen
2016-11-08 10:30 ` Borislav Petkov
2016-11-08 15:11 ` Thomas Gleixner [this message]
2016-11-08 8:52 ` [PATCH v4 2/2] cpuid: add AVX512_4VNNIW and AVX512_4FMAPS instructions support He Chen
2016-11-08 10:33 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1611081606310.3501@nanos \
--to=tglx@linutronix.de \
--cc=Piotr.Luc@intel.com \
--cc=bp@alien8.de \
--cc=he.chen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luwei.kang@intel.com \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome