From: Thomas Gleixner <tglx@linutronix.de>
To: Kan Liang <kan.liang@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
mingo@redhat.com, LKML <linux-kernel@vger.kernel.org>,
eranian@google.com, benjamin.widawsky@intel.com,
Andi Kleen <andi@firstfloor.org>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] perf/x86: add more Intel uncore IMC PCI ID for SkyLake
Date: Tue, 8 Nov 2016 18:04:22 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1611081757000.3501@nanos> (raw)
In-Reply-To: <1478555231-20143-1-git-send-email-kan.liang@intel.com>
On Mon, 7 Nov 2016, kan.liang@intel.com wrote:
> There are several PCI IDs are missed for Intel SkyLake IMC.
There are ... are ???
> This patch adds the PCI IDs for SkyLake Y, U, H and S platforms.
"This patch" is just a bad habit. We already know that this is a patch. See
Documentation/SubmittingPatches, which has an explanation for this.
> This patch also rename 0x191f and 0x190c according to the document.
You do not rename the hex constants. You rename the ID macros ...
> These PCI IDs are defined in the document as below.
>
> Y & U platforms
> http://www.intel.com/content/www/us/en/processors/core/
> 6th-gen-core-family-mobile-u-y-processor-lines-datasheet-vol-2.html
>
> S platform
> http://www.intel.com/content/www/us/en/processors/core/
> desktop-6th-gen-core-family-datasheet-vol-2.html
>
> H platform
> http://www.intel.com/content/www/us/en/processors/core/
> 6th-gen-core-family-mobile-h-processor-lines-datasheet-vol-2.html
As I said before several times. These links are just horrible. The Intel
webpage is restructured every so often, so the links might be stale before
thishits Linus tree. We really need persistant links, not just the link of
today.
One way to achive that is to open a bugzilla entry in the kernel org
bugzilla and stick the files there for permanent reference, unless Intel
comes up with something which is not affected by their constant web page
reshuffling.
Thanks,
tglx
prev parent reply other threads:[~2016-11-08 17:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 21:47 kan.liang
2016-11-07 23:56 ` Ben Widawsky
2016-11-08 17:04 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1611081757000.3501@nanos \
--to=tglx@linutronix.de \
--cc=andi@firstfloor.org \
--cc=benjamin.widawsky@intel.com \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®