From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933772AbcKHVQt (ORCPT <rfc822;w@1wt.eu>);
        Tue, 8 Nov 2016 16:16:49 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:56265 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932300AbcKHVQq (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 8 Nov 2016 16:16:46 -0500
Date: Tue, 8 Nov 2016 22:14:04 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Borislav Petkov <bp@alien8.de>
cc: "Luck, Tony" <tony.luck@intel.com>,
        linux-edac <linux-edac@vger.kernel.org>, X86 ML <x86@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/MCE: Remove MCP_TIMESTAMP
In-Reply-To: <20161108210819.gx7bfw7pfx4e6tf4@pd.tnic>
Message-ID: <alpine.DEB.2.20.1611082212140.3501@nanos>
References: <20161101120911.13163-1-bp@alien8.de> <20161105131104.drouavgezizz4w7v@pd.tnic> <3908561D78D1C84285E8C5FCA982C28F3A22720B@ORSMSX114.amr.corp.intel.com> <20161107180853.4uxlvtoychzhwr2q@pd.tnic> <3908561D78D1C84285E8C5FCA982C28F3A22728C@ORSMSX114.amr.corp.intel.com>
 <20161108180932.wvvcbbzrzrai26eg@pd.tnic> <alpine.DEB.2.20.1611082136380.3501@nanos> <20161108210819.gx7bfw7pfx4e6tf4@pd.tnic>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 8 Nov 2016, Borislav Petkov wrote:
> On Tue, Nov 08, 2016 at 09:39:02PM +0100, Thomas Gleixner wrote:
> > That does not make any sense. Where is m.tsc initialized? I couldn't find
> > any place which does, except this and the conditional clear farther down in
> > that function.
> 
> mce_gather_info->mce_setup does
> 
> m->tsc = rdtsc();
> 
> And we do that *everytime* but then we go and clear the damn thing. I
> know, I know, I wanted to flip that logic too and read the TSC *only*
> when we want a precise timestamp but that would require more changes as
> mce_setup() is used at a bunch of places.

And yes, you should spend the extra cycles. Adding a flags argument to
mce_setup() and propagate it through the various callsites shouldn't be
that hard and would make the stuff obvious instead of obfuscated.

Thanks,

	tglx