From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754579AbcKIXZ2 (ORCPT ); Wed, 9 Nov 2016 18:25:28 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:59557 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754384AbcKIXZ0 (ORCPT ); Wed, 9 Nov 2016 18:25:26 -0500 Date: Thu, 10 Nov 2016 00:22:44 +0100 (CET) From: Thomas Gleixner To: Andi Kleen cc: Andrew Morton , Vitaly Wool , Linux-MM , linux-kernel@vger.kernel.org, Dan Streetman Subject: Re: [PATCH v3] z3fold: use per-page read/write lock In-Reply-To: <20161109230117.GO26852@two.firstfloor.org> Message-ID: References: <20161109115531.81d2a3fd4313236d483510f0@gmail.com> <20161109143304.538885b06a4b5d2289da1e52@linux-foundation.org> <20161109230117.GO26852@two.firstfloor.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 9 Nov 2016, Andi Kleen wrote: > On Wed, Nov 09, 2016 at 02:33:04PM -0800, Andrew Morton wrote: > > On Wed, 9 Nov 2016 11:55:31 +0100 Vitaly Wool wrote: > > > > > Subject: [PATCH v3] z3fold: use per-page read/write lock > > > > I've rewritten the title to "mm/z3fold.c: use per-page spinlock" > > > > (I prefer to have "mm" in the title to easily identify it as an MM > > patch, and using "mm: z3fold: ..." seems odd when the actual pathname > > conveys the same info.) > > Still think it needs to be raw_spinlock_t, otherwise the build bug on > on the header size will break again. raw spinlocks in mainline are not smaller than spinlocks, that's only true for RT. What's smaller are arch spinlocks, but then they evade debugging as well. > Better would be to fix that build bug though Indeed. Thanks, tglx