From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S964840AbcKJVaL (ORCPT <rfc822;w@1wt.eu>);
        Thu, 10 Nov 2016 16:30:11 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:34385 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S934229AbcKJVaJ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 10 Nov 2016 16:30:09 -0500
Date: Thu, 10 Nov 2016 22:27:32 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: David Carrillo-Cisneros <davidcc@google.com>
cc: linux-kernel@vger.kernel.org, "x86@kernel.org" <x86@kernel.org>,
        Ingo Molnar <mingo@redhat.com>, Andi Kleen <ak@linux.intel.com>,
        Kan Liang <kan.liang@intel.com>, Peter Zijlstra <peterz@infradead.org>,
        Vegard Nossum <vegard.nossum@gmail.com>,
        Marcelo Tosatti <mtosatti@redhat.com>,
        Nilay Vaish <nilayvaish@gmail.com>, Borislav Petkov <bp@suse.de>,
        Vikas Shivappa <vikas.shivappa@linux.intel.com>,
        Ravi V Shankar <ravi.v.shankar@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>, Paul Turner <pjt@google.com>,
        Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH v3 06/46] perf/x86/intel/cmt: add intel_cmt pmu
In-Reply-To: <1477787923-61185-7-git-send-email-davidcc@google.com>
Message-ID: <alpine.DEB.2.20.1611102226250.3501@nanos>
References: <1477787923-61185-1-git-send-email-davidcc@google.com> <1477787923-61185-7-git-send-email-davidcc@google.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 29 Oct 2016, David Carrillo-Cisneros wrote:
>  static int __init cmt_alloc(void)
>  {
>  	cmt_l3_scale = boot_cpu_data.x86_cache_occ_scale;
> @@ -240,6 +339,7 @@ static int __init cmt_start(void)
>  		err = -ENOMEM;
>  		goto rm_online;
>  	}
> +	event_attr_intel_cmt_llc_scale.event_str = str;

And yes, that string dup should happen with this patch and not detached in
the previous one.

Thanks,

	tglx