From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S936584AbcKKJnv (ORCPT <rfc822;w@1wt.eu>);
        Fri, 11 Nov 2016 04:43:51 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:35217 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S934434AbcKKJnq (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 11 Nov 2016 04:43:46 -0500
Date: Fri, 11 Nov 2016 10:41:07 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
cc: David Carrillo-Cisneros <davidcc@google.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>, Ingo Molnar <mingo@redhat.com>,
        Andi Kleen <ak@linux.intel.com>, Kan Liang <kan.liang@intel.com>,
        Vegard Nossum <vegard.nossum@gmail.com>,
        Marcelo Tosatti <mtosatti@redhat.com>,
        Nilay Vaish <nilayvaish@gmail.com>, Borislav Petkov <bp@suse.de>,
        Vikas Shivappa <vikas.shivappa@linux.intel.com>,
        Ravi V Shankar <ravi.v.shankar@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>, Paul Turner <pjt@google.com>,
        Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH v3 05/46] perf/x86/intel/cmt: add per-package locks
In-Reply-To: <20161111072156.GS3568@worktop.programming.kicks-ass.net>
Message-ID: <alpine.DEB.2.20.1611111020450.3501@nanos>
References: <1477787923-61185-1-git-send-email-davidcc@google.com> <1477787923-61185-6-git-send-email-davidcc@google.com> <alpine.DEB.2.20.1611101619270.3501@nanos> <CALcN6miYhT1gVVOgMSLNCn9ksrRVZuXoiHUN-MCRKob1-JV-AA@mail.gmail.com>
 <20161111072156.GS3568@worktop.programming.kicks-ass.net>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 11 Nov 2016, Peter Zijlstra wrote:
> Well, its very hard to suggest alternatives, because there simply isn't
> anything of content here. This patch just adds locks, and the next few
> patches don't describe much either.
> 
> Why can't this be RCU?

AFAICT from looking at later patches the context switch path can do RMID
borrowing/stealing whatever things which need protection of the package
data. Other pathes (setup/rotation/ ...) take all the package locks to
prevent concurrent RMID operations.

I still have not figured out why all of this is necessary and unfortunately
there is no real coherent epxlanation of the overall design. The cover
letter is not really helpful either.

Thanks,

	tglx