From: Thomas Gleixner <tglx@linutronix.de>
To: Dave Jiang <dave.jiang@intel.com>
Cc: Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
dan.j.williams@intel.com, x86@kernel.org, david@fromorbit.com,
LKML <linux-kernel@vger.kernel.org>,
linux-nvdimm@ml01.01.org
Subject: Re: [PATCH] x86: Add warning when memmap=nn!ss and CONFIG_RANDOMIZE_BASE enabled
Date: Fri, 18 Nov 2016 12:33:35 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1611181224440.3615@nanos> (raw)
In-Reply-To: <147941499514.131046.6450643991764692220.stgit@djiang5-desk3.ch.intel.com>
On Thu, 17 Nov 2016, Dave Jiang wrote:
> CONFIG_RANDOMIZE_BASE can place the kernel anywhere. This causes a problem
> for when memmap=nn!ss is used. This information is not known until after
> the kernel starts executing and the decision for where the randomized
> base goes happens before the kernel is uncompressed. memmap=nn!ss is not
> reliable in the presence of CONFIG_RANDOMIZE_BASE.
So this is a description of a problem. Now what's missing is a useful
explanation why you think that adding a warning will make things better.
IMNSHO adding that warning is just a pointless exercise.
Why aren't you addressing the real issue and make the boot code parse that
option and prevent that region from being used for kernel placement?
The same issue exists for other memmap options as well, not just for that
PMEM thingy.
Thanks,
tglx
next prev parent reply other threads:[~2016-11-18 11:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 20:36 Dave Jiang
2016-11-18 11:33 ` Thomas Gleixner [this message]
2016-11-18 16:47 ` Dave Jiang
2016-11-18 17:07 ` Dan Williams
2016-11-18 17:13 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1611181224440.3615@nanos \
--to=tglx@linutronix.de \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=david@fromorbit.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=mingo@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®