mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: Ingo Molnar <mingo@kernel.org>,
	John Stultz <john.stultz@linaro.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Richard Cochran <richardcochran@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 1/4] time: alarmtimer: Add the trcepoints for alarmtimer
Date: Mon, 21 Nov 2016 09:56:00 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1611210954090.3514@nanos> (raw)
In-Reply-To: <CAMz4ku+ZZTp7HRV=XP3L0tnerSSmCK6hyJGH2P6U9XgC2xVOdA@mail.gmail.com>

On Mon, 21 Nov 2016, Baolin Wang wrote:
> On 21 November 2016 at 16:13, Ingo Molnar <mingo@kernel.org> wrote:
> > Hm, there's a weirdness here: if freezer_delta != 0 when alarmtimer_suspend() is
> > called then type might be '0', although it's not alarm_bases[0] this value is
> > picked up from.
> >
> > Wouldn't it be better to initialize 'type' to -1 instead? (And rename it to
> > min_type or so.)
> 
> Make sense. I will send out new patch to fix this. Thanks for your comments.

Can you please fix the subject line while at it? 'trcepoints' does not look right

Thanks,

	tglx

  reply	other threads:[~2016-11-21  8:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-19  4:50 [GIT PULL][PATCH 0/4] Timekeeping items for 4.10 John Stultz
2016-11-19  4:50 ` [PATCH 1/4] time: alarmtimer: Add the trcepoints for alarmtimer John Stultz
2016-11-21  8:13   ` Ingo Molnar
2016-11-21  8:46     ` Baolin Wang
2016-11-21  8:56       ` Thomas Gleixner [this message]
2016-11-21  9:02         ` Baolin Wang
2016-11-19  4:50 ` [PATCH 2/4] selftests/timers: Fix spelling mistake "Asyncrhonous" -> "Asynchronous" John Stultz
2016-11-19  4:50 ` [PATCH 3/4] timekeeping: Ignore the bogus sleep time if pm_trace is enabled John Stultz
2016-11-21  8:17   ` Ingo Molnar
2016-11-24  9:54     ` Chen, Yu C
2016-11-28 18:39       ` John Stultz
2016-11-28 23:45         ` Chen, Yu C
2016-11-19  4:50 ` [PATCH 4/4] timekeeping: clocksource_cyc2ns: Document intended range limitation John Stultz
2016-11-21  8:54   ` Ingo Molnar
2016-11-21 15:28     ` Chris Metcalf
2016-11-21 22:06       ` John Stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1611210954090.3514@nanos \
    --to=tglx@linutronix.de \
    --cc=baolin.wang@linaro.org \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®