From: Thomas Gleixner <tglx@linutronix.de>
To: Joel Fernandes <joelaf@google.com>
Cc: linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
John Stultz <john.stultz@linaro.org>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v2 1/2] timekeeping: Introduce a fast boot clock derived from fast monotonic clock
Date: Tue, 22 Nov 2016 23:29:49 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1611222222370.3495@nanos> (raw)
In-Reply-To: <1479766370-31311-1-git-send-email-joelaf@google.com>
On Mon, 21 Nov 2016, Joel Fernandes wrote:
> @@ -56,6 +56,12 @@ static struct timekeeper shadow_timekeeper;
> struct tk_fast {
> seqcount_t seq;
> struct tk_read_base base[2];
> +
> + /*
> + * first dimension is based on lower seq bit,
> + * second dimension is for offset type (real, boot, tai)
> + */
Can you figure out why there are comments above the struct which explain
the members in Kernel Doc format and not randomly formatted comments inside
the struct definition?
> + ktime_t offsets[2][TK_OFFS_MAX];
This bloats fast_tk_raw for no value, along with the extra stores in the
update function for fast_tk_raw which will never use that offset stuff.
Aside of that, I really have to ask the question whether it's really
necessary to add this extra bloat in storage, update and readout code for
something which is not used by most people.
What's wrong with adding a tracepoint into the boot offset update function
and let perf or the tracer inject the value of the boot offset into the
trace data when starting. The time adjustment can be done in
postprocessing.
That should be sufficient for tracing suspend/resume behaviour. If there is
not a really convincing reason for having that as a real trace clock then I
prefer to avoid that extra stuff.
Thanks,
tglx
next prev parent reply other threads:[~2016-11-22 22:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 22:12 Joel Fernandes
2016-11-21 22:12 ` [PATCH v2 2/2] trace: Add an option for boot clock as trace clock Joel Fernandes
2016-11-21 22:26 ` Steven Rostedt
2016-11-22 3:42 ` kbuild test robot
2016-11-22 22:29 ` Thomas Gleixner [this message]
2016-11-23 0:23 ` [PATCH v2 1/2] timekeeping: Introduce a fast boot clock derived from fast monotonic clock Joel Fernandes
2016-11-23 0:26 ` Joel Fernandes
2016-11-23 8:59 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1611222222370.3495@nanos \
--to=tglx@linutronix.de \
--cc=joelaf@google.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®