From: Thomas Gleixner <tglx@linutronix.de>
To: Grzegorz Andrejczuk <grzegorz.andrejczuk@intel.com>
Cc: mingo@redhat.com, hpa@zytor.com, x86@kernel.org,
linux-kernel@vger.kernel.org, Piotr.Luc@intel.com,
dave.hansen@linux.intel.com
Subject: Re: [PATCH v11 1/5] x86/msr: add MSR_MISC_FEATURE_ENABLES and RING3MWAIT bit
Date: Wed, 21 Dec 2016 21:23:40 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1612212122060.3424@nanos> (raw)
In-Reply-To: <1482241726-27310-2-git-send-email-grzegorz.andrejczuk@intel.com>
On Tue, 20 Dec 2016, Grzegorz Andrejczuk wrote:
>
> diff --git a/arch/x86/include/asm/msr-index.h b/arch/x86/include/asm/msr-index.h
> index 78f3760..55ffae0 100644
> --- a/arch/x86/include/asm/msr-index.h
> +++ b/arch/x86/include/asm/msr-index.h
> @@ -539,6 +539,12 @@
> #define MSR_IA32_MISC_ENABLE_IP_PREF_DISABLE_BIT 39
> #define MSR_IA32_MISC_ENABLE_IP_PREF_DISABLE (1ULL << MSR_IA32_MISC_ENABLE_IP_PREF_DISABLE_BIT)
>
> +/* MISC_FEATURE_ENABLES non-architectural features */
> +#define MSR_MISC_FEATURE_ENABLES 0x00000140
> +
> +#define MSR_MISC_FEATURE_ENABLES_RING3MWAIT_BIT 1
> +#define MSR_MISC_FEATURE_ENABLES_RING3MWAIT (1ULL << MSR_MISC_FEATURE_ENABLES_RING3MWAIT_BIT)
> +
This last define is not used anywhere. I told you before, but addressing my
review comments completely is an unduly burden, or what?
Thanks,
tglx
next prev parent reply other threads:[~2016-12-21 20:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-20 13:48 [PATCH v11 0/5] Enabling Ring 3 MONITOR/MWAIT feature for Knights Landing Grzegorz Andrejczuk
2016-12-20 13:48 ` [PATCH v11 1/5] x86/msr: add MSR_MISC_FEATURE_ENABLES and RING3MWAIT bit Grzegorz Andrejczuk
2016-12-21 20:23 ` Thomas Gleixner [this message]
2016-12-22 9:10 ` Andrejczuk, Grzegorz
2016-12-20 13:48 ` [PATCH v11 2/5] x86/elf: add HWCAP2 to expose ring 3 MONITOR/MWAIT Grzegorz Andrejczuk
2016-12-20 13:48 ` [PATCH v11 3/5] x86/cpufeature: add RING3MWAIT to CPU features Grzegorz Andrejczuk
2016-12-20 13:48 ` [PATCH v11 4/5] x86/cpufeature: enable RING3MWAIT for Knights Landing Grzegorz Andrejczuk
2016-12-20 18:31 ` [Patch " Grzegorz Andrejczuk
2016-12-21 20:24 ` Thomas Gleixner
2016-12-22 10:19 ` Andrejczuk, Grzegorz
2016-12-22 11:05 ` Thomas Gleixner
2016-12-22 11:37 ` Andrejczuk, Grzegorz
2016-12-22 14:20 ` Thomas Gleixner
2016-12-23 18:19 ` Andrejczuk, Grzegorz
2016-12-20 13:48 ` [PATCH v11 5/5] x86/cpufeature: enable RING3MWAIT for Knights Mill Grzegorz Andrejczuk
2017-01-03 22:09 ` [PATCH v11 0/5] Enabling Ring 3 MONITOR/MWAIT feature for Knights Landing Pavel Machek
2017-01-09 8:59 ` Thomas Gleixner
2017-01-09 9:12 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1612212122060.3424@nanos \
--to=tglx@linutronix.de \
--cc=Piotr.Luc@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=grzegorz.andrejczuk@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®