From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965502AbcLWNEB (ORCPT <rfc822;w@1wt.eu>);
        Fri, 23 Dec 2016 08:04:01 -0500
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:14112 "EHLO
        mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S965249AbcLWNEA (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 23 Dec 2016 08:04:00 -0500
X-IronPort-AV: E=Sophos;i="5.33,393,1477954800"; 
   d="scan'208";a="251381885"
Date: Fri, 23 Dec 2016 14:03:55 +0100 (CET)
From: Julia Lawall <julia.lawall@lip6.fr>
X-X-Sender: jll@hadrien
To: Guenter Roeck <linux@roeck-us.net>
cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-hwmon@vger.kernel.org, Jean Delvare <jdelvare@suse.com>
Subject: Re: [PATCH 00/66] use permission-specific DEVICE_ATTR variants
In-Reply-To: <42ae040d-9939-5e8e-2157-8f635a3f6ab4@roeck-us.net>
Message-ID: <alpine.DEB.2.20.1612231402210.4056@hadrien>
References: <1482408335-3435-1-git-send-email-Julia.Lawall@lip6.fr> <42ae040d-9939-5e8e-2157-8f635a3f6ab4@roeck-us.net>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Hi Julia,
>
> I noticed that drivers/hwmon/gl518sm.c was not converted. Running your script
> on it does not do anything. Any idea what might cause that ?

I believe that it is due to the following:

#define show(type, suffix, value)                                       \
static ssize_t show_##suffix(struct device *dev,                        \
                             struct device_attribute *attr, char *buf)  \
{                                                                       \
        struct gl518_data *data = gl518_update_device(dev);             \
        return sprintf(buf, "%d\n", type##_FROM_REG(data->value));      \
}


Coccinelle doesn't understand the relationship between this macro and the
show functions.

julia