From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S935715AbdADI5m (ORCPT <rfc822;w@1wt.eu>);
        Wed, 4 Jan 2017 03:57:42 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:49231 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753283AbdADI5j (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 4 Jan 2017 03:57:39 -0500
Date: Wed, 4 Jan 2017 09:54:12 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
cc: linux-kernel@vger.kernel.org, mingo@kernel.org, hpa@zytor.com,
        linux-tip-commits@vger.kernel.org
Subject: Re: [tip:timers/urgent] ktime: Get rid of the union
In-Reply-To: <20170103103634.GA25813@worktop.programming.kicks-ass.net>
Message-ID: <alpine.DEB.2.20.1701040953140.3620@nanos>
References: <tip-64dac5c9e0f5a933e4520f0cb689b7b143925207@git.kernel.org> <20170103103634.GA25813@worktop.programming.kicks-ass.net>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 3 Jan 2017, Peter Zijlstra wrote:

> On Sun, Dec 25, 2016 at 05:26:33AM -0800, tip-bot for Thomas Gleixner wrote:
> > Commit-ID:  64dac5c9e0f5a933e4520f0cb689b7b143925207
> > Gitweb:     http://git.kernel.org/tip/64dac5c9e0f5a933e4520f0cb689b7b143925207
> > Author:     Thomas Gleixner <tglx@linutronix.de>
> > AuthorDate: Sun, 25 Dec 2016 11:38:40 +0100
> > Committer:  Thomas Gleixner <tglx@linutronix.de>
> > CommitDate: Sun, 25 Dec 2016 13:11:50 +0100
> > 
> > ktime: Get rid of the union
> > 
> > ktime is a union because the initial implementation stored the time in
> > scalar nanoseconds on 64 bit machine and in a endianess optimized timespec
> > variant for 32bit machines. The Y2038 cleanup removed the timespec variant
> > and switched everything to scalar nanoseconds. The union remained, but
> > become completely pointless.
> > 
> > Get rid of the union and just keep ktime_t as simple typedef of type s64.
> 
> All good stuff. One question that remains is why keep the type while
> removing the cycles_t type?

That would have been a massive surgery which I was not able to pull off on
top of the other changes.

Thanks,

	tglx