From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750827AbdALTtQ (ORCPT ); Thu, 12 Jan 2017 14:49:16 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:60729 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750733AbdALTtO (ORCPT ); Thu, 12 Jan 2017 14:49:14 -0500 X-IronPort-AV: E=Sophos;i="5.33,219,1477954800"; d="scan'208";a="208952034" Date: Thu, 12 Jan 2017 20:46:05 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Dan Carpenter cc: Giuseppe Cavallaro , jpinto , Alexandre Torgue , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch net-next] stmmac: indent an if statement In-Reply-To: <20170112184631.GA12157@mwanda> Message-ID: References: <20170112184631.GA12157@mwanda> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 12 Jan 2017, Dan Carpenter wrote: > The break statement should be indented one more tab. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > index ac32f9e..4daa8a3 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > @@ -191,7 +191,7 @@ static int stmmac_dt_phy(struct plat_stmmacenet_data *plat, > for_each_child_of_node(np, plat->mdio_node) { > if (of_device_is_compatible(plat->mdio_node, > "snps,dwmac-mdio")) > - break; > + break; If there is a break, there is probably also a need for an of_node_put? julia > } > } > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >