From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751188AbdAQVcU (ORCPT <rfc822;w@1wt.eu>);
        Tue, 17 Jan 2017 16:32:20 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:46479 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750929AbdAQVbu (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 17 Jan 2017 16:31:50 -0500
Date: Tue, 17 Jan 2017 22:31:43 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Shivappa Vikas <vikas.shivappa@intel.com>
cc: Vikas Shivappa <vikas.shivappa@linux.intel.com>, davidcc@google.com,
        eranian@google.com, linux-kernel@vger.kernel.org, x86@kernel.org,
        hpa@zytor.com, mingo@kernel.org, peterz@infradead.org,
        ravi.v.shankar@intel.com, tony.luck@intel.com, fenghua.yu@intel.com,
        andi.kleen@intel.com, h.peter.anvin@intel.com
Subject: Re: [PATCH 05/12] x86/cqm,perf/core: Cgroup support prepare
In-Reply-To: <alpine.DEB.2.10.1701171221150.15892@vshiva-Udesk>
Message-ID: <alpine.DEB.2.20.1701172230230.3645@nanos>
References: <1483740005-23499-1-git-send-email-vikas.shivappa@linux.intel.com> <1483740005-23499-6-git-send-email-vikas.shivappa@linux.intel.com> <alpine.DEB.2.20.1701171439210.3495@nanos> <alpine.DEB.2.10.1701171221150.15892@vshiva-Udesk>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 17 Jan 2017, Shivappa Vikas wrote:
> On Tue, 17 Jan 2017, Thomas Gleixner wrote:
> 
> > On Fri, 6 Jan 2017, Vikas Shivappa wrote:
> > > @@ -741,7 +741,13 @@ static int intel_cqm_event_init(struct perf_event
> > > *event)
> > >  	INIT_LIST_HEAD(&event->hw.cqm_group_entry);
> > >  	INIT_LIST_HEAD(&event->hw.cqm_groups_entry);
> > > 
> > > -	event->destroy = intel_cqm_event_destroy;
> > 
> > I missed this in the first round, but tripped over it when looking at one
> > of the follow up patches.
> > 
> > How is that supposed to work?
> > 
> > 1) intel_cqm_event_destroy() is still in the code and unused which emits a
> >   compiler warning, but that can obviously be ignored for a good measure.
> > 
> > 2) How would any testing of this mess actually work?
> > 
> >   Not all all. Nothing ever tears down an event. So you just leave
> >   everything hanging around probably with dangling pointers left and
> >   right.
> 
> The terminate is defined in next patch.

I know and that does not make it any better. It's broken, end of story.

Thanks,

	tglx