mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Chris Wilson <chris@chris-wilson.co.uk>,
	LKML <linux-kernel@vger.kernel.org>,
	Hannes Reinecke <hare@suse.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Chen Fan <chen.fan.fnst@cn.fujitsu.com>,
	Alexander Potapenko <glider@google.com>,
	Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] softirq: Reserve a bit in tasklet.state for the user
Date: Mon, 23 Jan 2017 16:59:32 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1701231657380.3836@nanos> (raw)
In-Reply-To: <bda87fec-55ce-4fbc-2ad4-0f67b99baa34@kernel.dk>

On Mon, 23 Jan 2017, Jens Axboe wrote:

> On 01/23/2017 08:33 AM, Chris Wilson wrote:
> > Allow the user to communicate with the tasklet through the atomic state
> > field by assigning a bit for their use. This can be used, for example,
> > to differentiate between a tasklet called following an irq or from
> > process context, where some hardware state may only be valid after the
> > irq.
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Jens Axboe <axboe@kernel.dk>
> > Cc: Hannes Reinecke <hare@suse.com>
> > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > Cc: Chen Fan <chen.fan.fnst@cn.fujitsu.com>
> > Cc: Alexander Potapenko <glider@google.com>
> > ---
> >  include/linux/interrupt.h | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
> > index 53144e78a369..ab321552089b 100644
> > --- a/include/linux/interrupt.h
> > +++ b/include/linux/interrupt.h
> > @@ -542,7 +542,8 @@ struct tasklet_struct name = { NULL, 0, ATOMIC_INIT(1), func, data }
> >  enum
> >  {
> >  	TASKLET_STATE_SCHED,	/* Tasklet is scheduled for execution */
> > -	TASKLET_STATE_RUN	/* Tasklet is running (SMP only) */
> > +	TASKLET_STATE_RUN,	/* Tasklet is running (SMP only) */
> > +	TASKLET_STATE_USER	/* Reserved for use by the owner */
> >  };
> 
> I have no problem making that distinction, but it's impossible to ack
> this patch without having seen how you plan to utilize it, as the patch
> is meaningless on its own.

Right and w/o well defined semantics of this bit it's not at all
acceptable. tasklets have vagely semantics already, we really don't need to
increase that horror.

Thanks,

	tglx

  parent reply	other threads:[~2017-01-23 15:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-23 15:33 Chris Wilson
2017-01-23 15:44 ` Jens Axboe
2017-01-23 15:57   ` [PATCH] drm/i915: Only run execlist context-switch handler after an interrupt Chris Wilson
2017-01-23 15:59   ` Thomas Gleixner [this message]
2017-01-23 16:10     ` [PATCH] softirq: Reserve a bit in tasklet.state for the user Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1701231657380.3836@nanos \
    --to=tglx@linutronix.de \
    --cc=axboe@kernel.dk \
    --cc=bhelgaas@google.com \
    --cc=chen.fan.fnst@cn.fujitsu.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=glider@google.com \
    --cc=hare@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®