From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752175AbdAaNdm (ORCPT <rfc822;w@1wt.eu>);
        Tue, 31 Jan 2017 08:33:42 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:34750 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752042AbdAaNde (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 31 Jan 2017 08:33:34 -0500
Date: Tue, 31 Jan 2017 14:33:29 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
cc: x86@kernel.org, Borislav Petkov <bp@alien8.de>,
        Erik Veijola <erik.veijola@intel.com>, Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH] x86/mce: Make timer handling more robust
In-Reply-To: <alpine.DEB.2.20.1701310936080.3457@nanos>
Message-ID: <alpine.DEB.2.20.1701311432080.3457@nanos>
References: <alpine.DEB.2.20.1701310936080.3457@nanos>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 31 Jan 2017, Thomas Gleixner wrote:
> +static void mce_start_timer(struct timer_list *t)
>  {
>  	unsigned long iv = check_interval * HZ;
>  
>  	if (mca_cfg.ignore_ce || !iv)
>  		return;
>  
> -	per_cpu(mce_next_interval, cpu) = iv;
> -
> -	t->expires = round_jiffies(jiffies + iv);
> -	add_timer_on(t, cpu);
> +	this_cpu_write(mce_next_interval, iv);
> +	__start_timer(t, jiffies + iv);

Bah. That's wrong. Delta patch below:

--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -1782,7 +1782,7 @@ static void mce_start_timer(struct timer
 		return;
 
 	this_cpu_write(mce_next_interval, iv);
-	__start_timer(t, jiffies + iv);
+	__start_timer(t, iv);
 }
 
 static void __mcheck_cpu_setup_timer(void)