From: Thomas Gleixner <tglx@linutronix.de>
To: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Mike Galbraith <efault@gmx.de>, Ingo Molnar <mingo@elte.hu>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: tip: demise of tsk_cpus_allowed() and tsk_nr_cpus_allowed()
Date: Thu, 9 Feb 2017 09:59:00 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1702090957060.3604@nanos> (raw)
In-Reply-To: <20170209065727.GA6902@gmail.com>
On Thu, 9 Feb 2017, Ingo Molnar wrote:
> And -rt would do something like this in migration_disable()/enable():
>
> t->cpus_ptr = &cpumask_of(task_cpu(p));
> t->nr_cpus = 1;
>
> ...
>
> t->cpus_ptr = &t->cpus_mask;
> t->nr_cpus = cpumask_weight(t->cpus_mask);
>
> In addition to that we could cache the weight of the cpumask as an additional
> optimization:
>
> t->cpus_ptr = &t->cpus_mask;
> t->nr_cpus = t->cpus_mask_weight;
>
> It all looks like a pretty natural construct to me. The migration_disabled() flag
> spreads almost a hundred branches all across the scheduler.
I'm fine with that. Making the pointer const is clever and prevents people
from manipulating the wrong thing. If would be great if you could rework it
that way instead of just ripping all out.
Thanks,
tglx
prev parent reply other threads:[~2017-02-09 9:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 4:23 Mike Galbraith
2017-02-06 10:31 ` Ingo Molnar
2017-02-06 12:18 ` Mike Galbraith
2017-02-06 12:29 ` Ingo Molnar
2017-02-06 12:47 ` Mike Galbraith
2017-02-06 13:32 ` Peter Zijlstra
2017-02-06 22:23 ` Ingo Molnar
2017-02-08 10:20 ` Thomas Gleixner
2017-02-08 11:40 ` Peter Zijlstra
2017-02-09 6:45 ` Ingo Molnar
2017-02-09 6:57 ` Ingo Molnar
2017-02-09 8:51 ` Peter Zijlstra
2017-02-09 8:59 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1702090957060.3604@nanos \
--to=tglx@linutronix.de \
--cc=bigeasy@linutronix.de \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®