From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753259AbdBJLeh (ORCPT <rfc822;w@1wt.eu>);
        Fri, 10 Feb 2017 06:34:37 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:60035 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753196AbdBJLef (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 10 Feb 2017 06:34:35 -0500
Date: Fri, 10 Feb 2017 12:18:22 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Dmitry Vyukov <dvyukov@google.com>
cc: Andrey Ryabinin <aryabinin@virtuozzo.com>,
        Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
        "x86@kernel.org" <x86@kernel.org>,
        Tobias Regnery <tobias.regnery@gmail.com>,
        "Paul E . McKenney" <paulmck@linux.vnet.ibm.com>,
        Alexander Potapenko <glider@google.com>,
        kasan-dev <kasan-dev@googlegroups.com>,
        LKML <linux-kernel@vger.kernel.org>, stable <stable@vger.kernel.org>
Subject: Re: [PATCH] x86/mm/ptdump: Fix soft lockup in page table walker.
In-Reply-To: <CACT4Y+YnZ2FhpmxNNmzGmmOQGqrsZShStgg4n_AYx41cUVnXeQ@mail.gmail.com>
Message-ID: <alpine.DEB.2.20.1702101217220.4036@nanos>
References: <0d19ac08-88b0-675d-19bd-4cdc543fdb30@virtuozzo.com> <20170210095405.31802-1-aryabinin@virtuozzo.com> <CACT4Y+YnZ2FhpmxNNmzGmmOQGqrsZShStgg4n_AYx41cUVnXeQ@mail.gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 10 Feb 2017, Dmitry Vyukov wrote:
> This is the right thing to do per se, but I am concerned that now
> people will just suffers from slow boot (it can take literally
> minutes) and will not realize the root cause nor that it's fixable
> (e.g. with rodata=n) and will probably just blame KASAN for slowness.
> 
> Could we default this rodata check to n under KASAN? Or at least print
> some explanatory warning message before doing marking rodata (it
> should be printed right before "hang", so if you stare at it for a
> minute during each boot you realize that it may be related)? Or
> something along these lines. FWIW in my builds I just always disable
> the check.

That certainly makes sense and we emit such warnings in other places
already (lockdep, trace_printk ...)

Thanks,

	tglx