From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752833AbdBJLdR (ORCPT ); Fri, 10 Feb 2017 06:33:17 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:60029 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752775AbdBJLdO (ORCPT ); Fri, 10 Feb 2017 06:33:14 -0500 Date: Fri, 10 Feb 2017 12:32:27 +0100 (CET) From: Thomas Gleixner To: Bartosz Golaszewski cc: Marc Zyngier , Jonathan Corbet , linux-doc@vger.kernel.org, LKML Subject: Re: [PATCH] irqdesc: add memory managed version of irq_alloc_descs() In-Reply-To: <1486461654-26368-1-git-send-email-bgolaszewski@baylibre.com> Message-ID: References: <1486461654-26368-1-git-send-email-bgolaszewski@baylibre.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 7 Feb 2017, Bartosz Golaszewski wrote: > + > +int __devm_irq_alloc_descs(struct device *dev, int irq, unsigned int from, > + unsigned int cnt, int node, struct module *owner, > + const struct cpumask *affinity) This lacks the kernel doc comment explaining the interface. Other than that it's fine. See the other public functions in that file. Thanks, tglx