From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752925AbdBJMGC (ORCPT ); Fri, 10 Feb 2017 07:06:02 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:60128 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752700AbdBJMF5 (ORCPT ); Fri, 10 Feb 2017 07:05:57 -0500 Date: Fri, 10 Feb 2017 12:37:49 +0100 (CET) From: Thomas Gleixner To: Vladimir Murzin cc: linux-kernel@vger.kernel.org, Marc Zyngier Subject: Re: [PATCH] genirq: fix comment to __handle_domain_irq In-Reply-To: <1484053380-818-1-git-send-email-vladimir.murzin@arm.com> Message-ID: References: <1484053380-818-1-git-send-email-vladimir.murzin@arm.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 10 Jan 2017, Vladimir Murzin wrote: > NULL domain is valid parameter and handled as default irq domain by > irq_find_mapping(). Instead of using NULL domain, dedicated "lookup" > parameter should be used to indicate whether conversion of HW > interrupt to the logical one is needed or not. > > Cc: Thomas Gleixner > Cc: Marc Zyngier > Signed-off-by: Vladimir Murzin > --- > include/linux/irqdesc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/irqdesc.h b/include/linux/irqdesc.h > index c9be579..8f5f7d9 100644 > --- a/include/linux/irqdesc.h > +++ b/include/linux/irqdesc.h > @@ -156,7 +156,7 @@ static inline void generic_handle_irq_desc(struct irq_desc *desc) > /* > * Convert a HW interrupt number to a logical one using a IRQ domain, > * and handle the result interrupt number. Return -EINVAL if > - * conversion failed. Providing a NULL domain indicates that the > + * conversion failed. Providing lookup set to false indicates that the > * conversion has already been done. > */ We should just remove that comment completely as we have a proper and correct kernel doc annotation for that function where its implemented. Having two places to document stuff is just wrong. Thanks, tglx