From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752467AbdBJLre (ORCPT ); Fri, 10 Feb 2017 06:47:34 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:60057 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751238AbdBJLrc (ORCPT ); Fri, 10 Feb 2017 06:47:32 -0500 Date: Fri, 10 Feb 2017 12:46:39 +0100 (CET) From: Thomas Gleixner To: Baoquan He cc: linux-kernel@vger.kernel.org, x86@kernel.org, mingo@redhat.com, hpa@zytor.com Subject: Re: [PATCH] x86: Clean up a tiny description mistake in kernel ld script In-Reply-To: <1486041922-5515-1-git-send-email-bhe@redhat.com> Message-ID: References: <1486041922-5515-1-git-send-email-bhe@redhat.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2 Feb 2017, Baoquan He wrote: > Remove the redundent word "is". > > Signed-off-by: Baoquan He > --- > arch/x86/kernel/vmlinux.lds.S | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S > index e79f15f..f8f56b9 100644 > --- a/arch/x86/kernel/vmlinux.lds.S > +++ b/arch/x86/kernel/vmlinux.lds.S > @@ -8,8 +8,8 @@ > * > * > * Don't define absolute symbols until and unless you know that symbol > - * value is should remain constant even if kernel image is relocated > - * at run time. Absolute symbols are not relocated. If symbol value should > + * value should remain constant even if kernel image is relocated at And while at it we could make it a proper sentence: ... you know that the symbol value should .... even if the kernel .... > + * run time. Absolute symbols are not relocated. If symbol value should If the symbol value ... > * change if kernel is relocated, make the symbol section relative and if the kernel > * put it inside the section definition. > */ > -- > 2.5.5 > >