From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752336AbdBJP27 (ORCPT ); Fri, 10 Feb 2017 10:28:59 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:32960 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751802AbdBJP24 (ORCPT ); Fri, 10 Feb 2017 10:28:56 -0500 Date: Fri, 10 Feb 2017 16:28:28 +0100 (CET) From: Thomas Gleixner To: Steven Rostedt cc: LKML , Peter Zijlstra , Arjan van de Ven Subject: Re: timers: Make flags output in the timer_start tracepoint useful In-Reply-To: <20170210095135.45671d44@gandalf.local.home> Message-ID: References: <20170210091921.68f7ca19@gandalf.local.home> <20170210095135.45671d44@gandalf.local.home> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 10 Feb 2017, Steven Rostedt wrote: > On Fri, 10 Feb 2017 15:37:11 +0100 (CET) > Thomas Gleixner wrote: > > > > > --- a/include/trace/events/timer.h > > > > +++ b/include/trace/events/timer.h > > > > @@ -36,6 +36,13 @@ DEFINE_EVENT(timer_class, timer_init, > > > > TP_ARGS(timer) > > > > ); > > > > > > > > +#define decode_timer_flags(flags) \ > > > > + __print_flags(flags, "|", \ > > > > + { TIMER_MIGRATING, "M" }, \ > > > > + { TIMER_DEFERRABLE, "D" }, \ > > > > + { TIMER_PINNED, "P" }, \ > > > > + { TIMER_IRQSAFE, "I" }) > > > > + > > > > /** > > > > * timer_start - called when the timer is started > > > > * @timer: pointer to struct timer_list > > > > @@ -65,9 +72,12 @@ TRACE_EVENT(timer_start, > > > > __entry->flags = flags; > > > > ), > > > > > > > > - TP_printk("timer=%p function=%pf expires=%lu [timeout=%ld] flags=0x%08x", > > > > + TP_printk("timer=%p function=%pf expires=%lu [timeout=%ld] cpu=%u idx=%u flags=%s", > > > > __entry->timer, __entry->function, __entry->expires, > > > > - (long)__entry->expires - __entry->now, __entry->flags) > > > > + (long)__entry->expires - __entry->now, > > > > + __entry->flags & TIMER_CPUMASK, > > > > + __entry->flags >> TIMER_ARRAYSHIFT, > > > > + decode_timer_flags(__entry->flags & TIMER_TRACE_FLAGMASK)) > > > > > > Hi Thomas, > > > > > > This all looks good, but I can't find TIMER_TRACE_FLAGMASK. Was that > > > added by another patch? > > > > -ENO_QUILT_REFRESH .... > > I'm wondering if it wouldn't just make sense to add another mask in > include/linux/timer.h along with the other TIMER macros? That's the missing hunk from timer.h which I did not refresh after testing it .... --- a/include/linux/timer.h +++ b/include/linux/timer.h @@ -66,6 +66,8 @@ struct timer_list { #define TIMER_ARRAYSHIFT 22 #define TIMER_ARRAYMASK 0xFFC00000 +#define TIMER_TRACE_FLAGMASK (TIMER_MIGRATING | TIMER_DEFERRABLE | TIMER_PINNED | TIMER_IRQSAFE) + #define __TIMER_INITIALIZER(_function, _expires, _data, _flags) { \ .entry = { .next = TIMER_ENTRY_STATIC }, \ .function = (_function), \