mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Kishore Karanala <kishore.karanala@gmail.com>
Cc: glx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	matt@codeblueprint.co.uk, rafael.j.wysocki@intel.com,
	thgarnie@google.com, arbab@linux.vnet.ibm.com,
	dave.hansen@linux.intel.com
Subject: Re: [PATCH] Staging: arch/x86/kernel/setup.c : fixed empty line style issue
Date: Sat, 11 Feb 2017 20:53:04 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1702112052060.3734@nanos> (raw)
In-Reply-To: <1486834221-3930-1-git-send-email-kishore.karanala@gmail.com>

On Sat, 11 Feb 2017, Kishore Karanala wrote:

> From: Kishore <kishore.karanala@gmail.com>
> 
> Fixed empty line style issue

What? There is no issue. These empty lines are entirely correct and
removing them is just hurting readability.

Thanks,

	tglx

> Signed-off-by: Kishore Karanala <kishore.karanala@gmail.com>
> ---
>  arch/x86/kernel/setup.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index 4cfba94..6d35649 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -723,7 +723,6 @@ static void __init trim_snb_memory(void)
>  	 * already been reserved.
>  	 */
>  	memblock_reserve(0, 1<<20);
> -	
>  	for (i = 0; i < ARRAY_SIZE(bad_pages); i++) {
>  		if (memblock_reserve(bad_pages[i], PAGE_SIZE))
>  			printk(KERN_WARNING "failed to reserve 0x%08lx\n",
> @@ -815,7 +814,6 @@ static void __init trim_low_memory_range(void)
>  {
>  	memblock_reserve(0, ALIGN(reserve_low, PAGE_SIZE));
>  }
> -	
>  /*
>   * Dump out kernel offset information on panic.
>   */
> -- 
> 2.7.4
> 
> 

      reply	other threads:[~2017-02-11 19:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-11 17:30 Kishore Karanala
2017-02-11 19:53 ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1702112052060.3734@nanos \
    --to=tglx@linutronix.de \
    --cc=arbab@linux.vnet.ibm.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=glx@linutronix.de \
    --cc=hpa@zytor.com \
    --cc=kishore.karanala@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@codeblueprint.co.uk \
    --cc=mingo@redhat.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=thgarnie@google.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®