From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751106AbdBKUfT (ORCPT ); Sat, 11 Feb 2017 15:35:19 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:35742 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750940AbdBKUfS (ORCPT ); Sat, 11 Feb 2017 15:35:18 -0500 Date: Sat, 11 Feb 2017 21:35:14 +0100 (CET) From: Thomas Gleixner To: Bhumika Goyal cc: julia.lawall@lip6.fr, linux-kernel@vger.kernel.org, mark.rutland@arm.com, marc.zyngier@arm.com, daniel.lezcano@linaro.org, linux-arm-kernel@lists.infradead.org, keescook@chromium.org Subject: Re: [PATCH] clocksource: add __ro_after_init to cyclecounter In-Reply-To: <1486840818-22214-1-git-send-email-bhumirks@gmail.com> Message-ID: References: <1486840818-22214-1-git-send-email-bhumirks@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 12 Feb 2017, Bhumika Goyal wrote: Please be more careful with your subject line. The prefix for this is definitely not 'clocksource'. git log would have told you the proper one: clocksource/drivers/arm_arch_timer 'clocksource' is the general subsystem and used for system wide changes or core changes, but not for a particular driver. > The object cyclecounter of type cyclecounter is not getting modified > after getting initialized by arch_counter_register. Apart from > initialization in arch_counter_register it is also passed as an argument > to the function timecounter_init but this argument is of type const. > Therefore, add __ro_after_init to its declaration. Other than that this is fine. I'll fix it up when applying. Thanks, tglx