From: Thomas Gleixner <tglx@linutronix.de>
To: Kishore Karanala <kishore.karanala@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, LKML <linux-kernel@vger.kernel.org>,
matt@codeblueprint.co.uk, rafael.j.wysocki@intel.com,
thgarnie@google.com, arbab@linux.vnet.ibm.com,
dave.hansen@linux.intel.com
Subject: Re: [PATCH 2/2] Staging: setup.c: fixed ERROR: trailing whitespace
Date: Sun, 12 Feb 2017 11:42:56 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1702121131280.3734@nanos> (raw)
In-Reply-To: <1486887260-2610-1-git-send-email-kishore.karanala@gmail.com>
On Sun, 12 Feb 2017, Kishore Karanala wrote:
You're not listening at all. I told you before:
The proper subsystem for x86 is x86 and not staging.
You can chose to ignore my review comments, but then you don't have to
wonder that I'm going to ignore you as well.
Aside of that, you got at least TWO messages from your mail server, that
mail to 'glx@linutronix.de' cannot be delivered, but that seems to be
information to ignore as well.
> Fixed ERROR: trailing whitespace issues
What's the point of this?
You used checkpatch.pl on that file. Can you figure out from the name of
that script what's the purpose of that script?
The purpose is obviously to check patches for correctness. The fact that
you can run checkpatch.pl with the -f commandline option on an existing
file does not change that.
And trailing whitespace is the least of our worries, really.
Thanks,
tglx
prev parent reply other threads:[~2017-02-12 10:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-12 8:14 Kishore Karanala
2017-02-12 10:42 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1702121131280.3734@nanos \
--to=tglx@linutronix.de \
--cc=arbab@linux.vnet.ibm.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kishore.karanala@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=thgarnie@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®