From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751333AbdBLK5Q (ORCPT ); Sun, 12 Feb 2017 05:57:16 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:36293 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751131AbdBLK5P (ORCPT ); Sun, 12 Feb 2017 05:57:15 -0500 Date: Sun, 12 Feb 2017 11:57:11 +0100 (CET) From: Thomas Gleixner To: "Tobin C. Harding" cc: linux-kernel@vger.kernel.org, Ingo Molnar , "H. Peter Anvin" , x86@kernel.org Subject: Re: [PATCH 1/2] arch/x86: Fix sparse warning symbol not declared In-Reply-To: <1486881870-2490-2-git-send-email-me@tobin.cc> Message-ID: References: <1486881870-2490-1-git-send-email-me@tobin.cc> <1486881870-2490-2-git-send-email-me@tobin.cc> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 12 Feb 2017, Tobin C. Harding wrote: A few nitpicks. > Subject: [PATCH 1/2] arch/x86: Fix sparse warning symbol not declared arch/x86: is not the correct prefix. Run git log on a file to figure out what the usual prefix is. The file was checked in with 'purgatory', but I'd prefer 'x86/purgatory' for future changes. > This patch adds static declaration to a number of variables. Fixes > sparse symbol was not declared warnings. Please read 'Documentation...SubmittingPatches' and look for 'This patch'. I give you an example for a changelog: Sparse emits several 'symbol not declared' warnings. Make the variables and functions, which have only file scope static. Now try to map that to the advise in Documentation. Thanks, tglx