From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751905AbdBMJzy (ORCPT ); Mon, 13 Feb 2017 04:55:54 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:38220 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751480AbdBMJzx (ORCPT ); Mon, 13 Feb 2017 04:55:53 -0500 Date: Mon, 13 Feb 2017 10:55:50 +0100 (CET) From: Thomas Gleixner To: Marc Zyngier cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, Christoffer Dall , Jason Cooper , Eric Auger Subject: Re: [RFC PATCH 05/33] irqchip/gic-v3-its: Zero command on allocation In-Reply-To: <1484648454-21216-6-git-send-email-marc.zyngier@arm.com> Message-ID: References: <1484648454-21216-1-git-send-email-marc.zyngier@arm.com> <1484648454-21216-6-git-send-email-marc.zyngier@arm.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Jan 2017, Marc Zyngier wrote: > When reusing commands from the ring buffer, it would be better > to zero them out, even if the ITS should ignore the unused > fields. > > Signed-off-by: Marc Zyngier > --- > drivers/irqchip/irq-gic-v3-its.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c > index 2ca27f6..9304dd2 100644 > --- a/drivers/irqchip/irq-gic-v3-its.c > +++ b/drivers/irqchip/irq-gic-v3-its.c > @@ -426,6 +426,12 @@ static struct its_cmd_block *its_allocate_entry(struct its_node *its) > if (its->cmd_write == (its->cmd_base + ITS_CMD_QUEUE_NR_ENTRIES)) > its->cmd_write = its->cmd_base; > > + /* Clear command */ > + cmd->raw_cmd[0] = 0; > + cmd->raw_cmd[1] = 0; > + cmd->raw_cmd[2] = 0; > + cmd->raw_cmd[3] = 0; memset ? Thanks, tglx