From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752181AbdBMPt4 (ORCPT ); Mon, 13 Feb 2017 10:49:56 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:40378 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752070AbdBMPtZ (ORCPT ); Mon, 13 Feb 2017 10:49:25 -0500 Date: Mon, 13 Feb 2017 16:49:18 +0100 (CET) From: Thomas Gleixner To: "Kirill A. Shutemov" cc: =?ISO-8859-15?Q?J=E9r=E9my_Lefaure?= , x86@kernel.org, Borislav Petkov , LKML Subject: Re: [PATCH] x86/vm86: fix unused variable warning if THP is disabled. In-Reply-To: <20170213125228.63645-1-kirill.shutemov@linux.intel.com> Message-ID: References: <20170213100352.p2cgpbehza2hloji@pd.tnic> <20170213125228.63645-1-kirill.shutemov@linux.intel.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-671934318-1487000958=:3619" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-671934318-1487000958=:3619 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Mon, 13 Feb 2017, Kirill A. Shutemov wrote: > GCC complaines on unused variable 'vma' in mark_screen_rdonly() if THP > is disalbed: > > arch/x86/kernel/vm86_32.c: In function ‘mark_screen_rdonly’: > arch/x86/kernel/vm86_32.c:180:26: warning: unused variable ‘vma’ > [-Wunused-variable] > struct vm_area_struct *vma = find_vma(mm, 0xA0000); > ^~~ > It shoudln't really. The whole block has to be eliminated as > pmd_trans_huge() is 0 if THP is disabled. Indeed. That's outright silly. --8323329-671934318-1487000958=:3619--