From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753236AbdBMVYI (ORCPT <rfc822;w@1wt.eu>);
        Mon, 13 Feb 2017 16:24:08 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:41312 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752199AbdBMVYH (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 13 Feb 2017 16:24:07 -0500
Date: Mon, 13 Feb 2017 22:24:01 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Tobin Harding <me@tobin.cc>
cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org
Subject: Re: [PATCH 2/2] arch/x86: Fix sparse warning symbol not declared
In-Reply-To: <20170213202649.GA24878@eros>
Message-ID: <alpine.DEB.2.20.1702132204010.8088@nanos>
References: <1486881870-2490-1-git-send-email-me@tobin.cc> <1486881870-2490-3-git-send-email-me@tobin.cc> <alpine.DEB.2.20.1702121157150.3734@nanos> <20170213202649.GA24878@eros>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 14 Feb 2017, Tobin Harding wrote:
> On Sun, Feb 12, 2017 at 12:06:47PM +0100, Thomas Gleixner wrote:
> > The proper solution is to have a local include file 'purgatory.h' and put
> > the declaration there. Include it in both files even if that's not required
> > for the ASM file. But that documents, that the function is used outside of
> > purgatory.c
> 
> Blindly following instructions led to the bone headed patch I
> submitted yesterday (without building). Is there some way to include a
> C header in an ASM file that I do not know about?

Yes, you have to guard the function declaration with

#ifndef __ASSEMBLY__

I did not think about that when I suggested this. Brainslip :)

So yes, it's kinda pointless, but it still has documentatory value and
keeps the sparse build clean.

> Thanks for patiently pointing out how to write a commit log. May I
> please bother you with another small etiquette question. Should I
> have replayed to you as I have done so or should I have re-sent another
> patch (v3) with the mistakes fixed (and stated in the log that I did
> not know how to implement the suggestions).

All good. Either way works as long as you notice your own mistakes. It's
also fine to tell me that I suggested nonsense. :)

Thanks,

	tglx