From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933134AbdBPSLz (ORCPT ); Thu, 16 Feb 2017 13:11:55 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:53510 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933056AbdBPSLx (ORCPT ); Thu, 16 Feb 2017 13:11:53 -0500 Date: Thu, 16 Feb 2017 19:11:36 +0100 (CET) From: Thomas Gleixner To: Andrew Banman cc: mingo@redhat.com, akpm@linux-foundation.org, hpa@zytor.com, mike.travis@hpe.com, rja@hpe.com, sivanich@hpe.com, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] x86/platform/uv/BAU: Add wait_completion to bau_operations In-Reply-To: <1487123931-56809-4-git-send-email-abanman@hpe.com> Message-ID: References: <1487123931-56809-1-git-send-email-abanman@hpe.com> <1487123931-56809-4-git-send-email-abanman@hpe.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Feb 2017, Andrew Banman wrote: > Remove the present wait_completion routine and add a function pointer by > the same name to the bau_operations struct. Rather than switching on the > UV hub version during message processing, set the architecture-specific > uv*_wait_completion during initialization. Well written changelog! > +static int uv1_wait_completion(struct bau_desc *bau_desc, > + struct bau_control *bcp, long try); > +static int uv2_3_wait_completion(struct bau_desc *bau_desc, > + struct bau_control *bcp, long try); You could spare the forward declarations by moving the uv*_bau_ops down right before uv_bau_init(). And while at it, the uv*_bau_ops can be made __initconst. > static struct bau_operations ops; That one can be made __ro_after_init as the only possible modification happens in the init function. Thanks, tglx