From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933364AbdBPS2p (ORCPT ); Thu, 16 Feb 2017 13:28:45 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:53685 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932302AbdBPS2o (ORCPT ); Thu, 16 Feb 2017 13:28:44 -0500 Date: Thu, 16 Feb 2017 19:28:30 +0100 (CET) From: Thomas Gleixner To: Andrew Banman cc: mingo@redhat.com, akpm@linux-foundation.org, hpa@zytor.com, mike.travis@hpe.com, rja@hpe.com, sivanich@hpe.com, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/6] x86/platform/uv/BAU: Remove initial write to swack register In-Reply-To: <1487123931-56809-6-git-send-email-abanman@hpe.com> Message-ID: References: <1487123931-56809-1-git-send-email-abanman@hpe.com> <1487123931-56809-6-git-send-email-abanman@hpe.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Feb 2017, Andrew Banman wrote: > Writing to the software acknowledge clear register when there are no > pending messages causes a HUB error to assert. The original intent of this > write was to clear the pending bits before start of operation, but this is > an incorrect method and has been determined to be unnecessary. This is a bug fix, independent of the rest of the series, right? So it should go to the beginning of that series or even better sent out as a seperate patch so it can be picked up right away. Hiding bug fixes in the middle of a functional/feature series makes them slip through. Thanks, tglx