From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933415AbdBPTv0 (ORCPT ); Thu, 16 Feb 2017 14:51:26 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:7025 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932761AbdBPTvZ (ORCPT ); Thu, 16 Feb 2017 14:51:25 -0500 X-IronPort-AV: E=Sophos;i="5.35,169,1484002800"; d="scan'208";a="260837848" Date: Thu, 16 Feb 2017 20:51:05 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: simran singhal cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH 1/3] staging: rtl8192u: Replace symbolic permissions with octal permissions In-Reply-To: <20170216194556.GA30632@singhal-Inspiron-5558> Message-ID: References: <20170216194556.GA30632@singhal-Inspiron-5558> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 17 Feb 2017, simran singhal wrote: > WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. > Consider using octal permissions '0644'. > This warning is detected by checkpatch.pl This one has all the pieces in the right place, but please redo with the suggestions on the previous version. julia > Signed-off-by: simran singhal > --- > drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c > index a9a92d8..2ebc320 100644 > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c > @@ -283,7 +283,7 @@ int __init ieee80211_debug_init(void) > " proc directory\n"); > return -EIO; > } > - e = proc_create("debug_level", S_IRUGO | S_IWUSR, > + e = proc_create("debug_level", 0644, > ieee80211_proc, &fops); > if (!e) { > remove_proc_entry(DRV_NAME, init_net.proc_net); > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170216194556.GA30632%40singhal-Inspiron-5558. > For more options, visit https://groups.google.com/d/optout. >