From: Thomas Gleixner <tglx@linutronix.de>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org,
Tvrtko Ursulin <tvrtko.ursulin@intel.com>,
Hannes Reinecke <hare@suse.com>, Jens Axboe <axboe@kernel.dk>,
Bjorn Helgaas <bhelgaas@google.com>,
Alexander Potapenko <glider@google.com>,
Chen Fan <chen.fan.fnst@cn.fujitsu.com>,
Ingo Molnar <mingo@kernel.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Johannes Thumshirn <jthumshirn@suse.de>,
Emese Revfy <re.emese@gmail.com>,
Sagi Grimberg <sagi@grimberg.me>,
Eric Dumazet <edumazet@google.com>,
Tom Herbert <therbert@google.com>,
Ben Hutchings <bhutchings@solarflare.com>
Subject: Re: [PATCH v3] softirq: Prevent looping on disabled tasklets
Date: Fri, 17 Feb 2017 12:55:56 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1702171255150.3536@nanos> (raw)
In-Reply-To: <20170212160335.GD14326@nuc-i3427.alporthouse.com>
On Sun, 12 Feb 2017, Chris Wilson wrote:
> On Sun, Feb 12, 2017 at 03:46:09PM +0000, Chris Wilson wrote:
> > +void tasklet_enable(struct tasklet_struct *t)
> > +{
> > + if (!atomic_dec_and_test(&t->count))
> > + return;
> > +
> > + if (test_bit(TASKLET_STATE_SCHED, &t->state))
> > + raise_softirq(HI_SOFTIRQ | TASKLET_SOFTIRQ);
>
> And of course this can't work as raise_softirq() is local to the cpu.
Indeed. tasklets are a horror by design. We rather should make them go away.
Thanks,
tglx
prev parent reply other threads:[~2017-02-17 11:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-12 14:00 [PATCH] " Chris Wilson
2017-02-12 14:23 ` Chris Wilson
2017-02-12 14:31 ` [PATCH v2] " Chris Wilson
2017-02-12 15:04 ` [Intel-gfx] [PATCH] " kbuild test robot
2017-02-12 15:16 ` kbuild test robot
2017-02-12 15:46 ` [PATCH v3] " Chris Wilson
2017-02-12 16:03 ` Chris Wilson
2017-02-17 11:55 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1702171255150.3536@nanos \
--to=tglx@linutronix.de \
--cc=axboe@kernel.dk \
--cc=bhelgaas@google.com \
--cc=bhutchings@solarflare.com \
--cc=bigeasy@linutronix.de \
--cc=chen.fan.fnst@cn.fujitsu.com \
--cc=chris@chris-wilson.co.uk \
--cc=edumazet@google.com \
--cc=glider@google.com \
--cc=hare@suse.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=re.emese@gmail.com \
--cc=sagi@grimberg.me \
--cc=therbert@google.com \
--cc=tvrtko.ursulin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®