From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753146AbdBRNao (ORCPT ); Sat, 18 Feb 2017 08:30:44 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:45417 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752088AbdBRNam (ORCPT ); Sat, 18 Feb 2017 08:30:42 -0500 X-IronPort-AV: E=Sophos;i="5.35,174,1484002800"; d="scan'208";a="261083686" Date: Sat, 18 Feb 2017 14:30:36 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Arushi Singhal cc: arnaud.patard@rtp-net.org, Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH] staging: xgifb: function definition argument should also have an identifier name' In-Reply-To: <20170218132356.GA4907@arushi-HP-Pavilion-Notebook> Message-ID: References: <20170218132356.GA4907@arushi-HP-Pavilion-Notebook> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 18 Feb 2017, Arushi Singhal wrote: > function definition argument 'struct vb_device_info *' and 'unsigned > long' should also have an identifier name. This could be a bit more clear as "Add variable names to function prototype parameter list." > > Signed-off-by: Arushi Singhal > --- > drivers/staging/xgifb/vb_init.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/xgifb/vb_init.h b/drivers/staging/xgifb/vb_init.h > index 500cabe41a3c..e4929314d33e 100644 > --- a/drivers/staging/xgifb/vb_init.h > +++ b/drivers/staging/xgifb/vb_init.h > @@ -1,6 +1,6 @@ > #ifndef _VBINIT_ > #define _VBINIT_ > unsigned char XGIInitNew(struct pci_dev *pdev); > -void XGIRegInit(struct vb_device_info *, unsigned long); > +void XGIRegInit(struct vb_device_info *pVBInfo, unsigned long BaseAddr); Actually, you should use the same names as found in the definition of the function, which seem to be: void XGIRegInit(struct vb_device_info *XGI_Pr, unsigned long BaseAddr) julia > #endif > > -- > 2.11.0 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170218132356.GA4907%40arushi-HP-Pavilion-Notebook. > For more options, visit https://groups.google.com/d/optout. >