From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753280AbdBRPay (ORCPT ); Sat, 18 Feb 2017 10:30:54 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:55563 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751532AbdBRPax (ORCPT ); Sat, 18 Feb 2017 10:30:53 -0500 X-IronPort-AV: E=Sophos;i="5.35,174,1484002800"; d="scan'208";a="261091632" Date: Sat, 18 Feb 2017 16:30:44 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: simran singhal cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH 3/6] staging: rtl8192e: Fix block comments warning In-Reply-To: <20170218152351.GA28908@singhal-Inspiron-5558> Message-ID: References: <20170218152351.GA28908@singhal-Inspiron-5558> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 18 Feb 2017, simran singhal wrote: > Align * on a line, to conform to the kernal coding > style for block comments. It is not clear what is means to align * on a line. What line? What has been done is to add a space at the beginning of the line. But then the line goes over 80 characters and doesn't line up any more on the right side. I would guess that you should have gotten a new warning by having gone over 80 characters. Fixing one warning should not introduce a new one, especially for something purely decorative, like this. julia > > Signed-off-by: simran singhal > --- > drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h > index 6eb018f..48d101a 100644 > --- a/drivers/staging/rtl8192e/rtl819x_HT.h > +++ b/drivers/staging/rtl8192e/rtl819x_HT.h > @@ -11,7 +11,7 @@ > * > * Contact Information: > * wlanfae > -******************************************************************************/ > + ******************************************************************************/ > #ifndef _RTL819XU_HTTYPE_H_ > #define _RTL819XU_HTTYPE_H_ > > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170218152351.GA28908%40singhal-Inspiron-5558. > For more options, visit https://groups.google.com/d/optout. >