From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754988AbdBRVMA (ORCPT ); Sat, 18 Feb 2017 16:12:00 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:37634 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753585AbdBRVL7 (ORCPT ); Sat, 18 Feb 2017 16:11:59 -0500 X-IronPort-AV: E=Sophos;i="5.35,176,1484002800"; d="scan'208";a="261112234" Date: Sat, 18 Feb 2017 22:11:46 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: simran singhal cc: forest@alittletooquiet.net, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH v2 1/6] staging: vt6655: Compress return logic In-Reply-To: <20170218210740.GA14258@singhal-Inspiron-5558> Message-ID: References: <20170218210740.GA14258@singhal-Inspiron-5558> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 19 Feb 2017, simran singhal wrote: > gregkh@linuxfoundation.org,devel@driverdev.osuosl.org,linux-kernel@vger.kernel.org,outreachy-kernel@googlegroups.com > Bcc: > Subject: [PATCH v2 1/6] staging: vt6655: Compress return logic > Reply-To: This didn't come out well. > > Simplify function returns by merging assignment and return into > one command line. > Found with Coccinelle > @@ > local idexpression ret; > expression e; > @@ > > -ret = > +return > e; > -return ret; > > Signed-off-by: simran singhal > --- > > v2: > -Removed assignment > > drivers/staging/vt6655/card.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c > index e0c9281..9a8999f 100644 > --- a/drivers/staging/vt6655/card.c > +++ b/drivers/staging/vt6655/card.c > @@ -918,9 +918,7 @@ u64 CARDqGetTSFOffset(unsigned char byRxRate, u64 qwTSF1, u64 qwTSF2) > > qwTSF2 += (u64)wRxBcnTSFOffst; > > - qwTSFOffset = qwTSF1 - qwTSF2; > - > - return qwTSFOffset; > + return qwTSF1 - qwTSF2; It's not just the assignment that can go. All mentions of the variable are useless, ie the declaration too. julia > } > > /* > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170218210740.GA14258%40singhal-Inspiron-5558. > For more options, visit https://groups.google.com/d/optout. >