From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934552AbdBVVLx (ORCPT ); Wed, 22 Feb 2017 16:11:53 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:3647 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755028AbdBVVKm (ORCPT ); Wed, 22 Feb 2017 16:10:42 -0500 X-IronPort-AV: E=Sophos;i="5.35,196,1484002800"; d="scan'208";a="261704405" Date: Wed, 22 Feb 2017 22:08:44 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: "Tobin C. Harding" cc: Petr Vandrovec , Jan Kara , Miklos Szeredi , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ncpfs: Remove cast from memory allocation In-Reply-To: <1487797394-30306-1-git-send-email-me@tobin.cc> Message-ID: References: <1487797394-30306-1-git-send-email-me@tobin.cc> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 23 Feb 2017, Tobin C. Harding wrote: > Coccinelle emits WARNING: casting value returned by memory allocation > function to (struct ncp_inode_info *) is useless. > > Remove unnecessary cast. > > Changes since v1: > - Fix up typo Changes since v1 goes below the ---. When this ends up in the git history, no one will care about the changes since v1, because v1 won't be part of the history. julia > > Signed-off-by: Tobin C. Harding > --- > > Kernel built successfully with patch applied. > > fs/ncpfs/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ncpfs/inode.c b/fs/ncpfs/inode.c > index 7eb89c2..7a9ed33 100644 > --- a/fs/ncpfs/inode.c > +++ b/fs/ncpfs/inode.c > @@ -52,7 +52,7 @@ static struct kmem_cache * ncp_inode_cachep; > static struct inode *ncp_alloc_inode(struct super_block *sb) > { > struct ncp_inode_info *ei; > - ei = (struct ncp_inode_info *)kmem_cache_alloc(ncp_inode_cachep, GFP_KERNEL); > + ei = kmem_cache_alloc(ncp_inode_cachep, GFP_KERNEL); > if (!ei) > return NULL; > return &ei->vfs_inode; > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >