From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751306AbdBXGsi (ORCPT ); Fri, 24 Feb 2017 01:48:38 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:9224 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750973AbdBXGsb (ORCPT ); Fri, 24 Feb 2017 01:48:31 -0500 X-IronPort-AV: E=Sophos;i="5.35,200,1484002800"; d="scan'208";a="261885124" Date: Fri, 24 Feb 2017 07:48:19 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Shubhrajyoti Datta cc: Michal Simek , Michael Turquette , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, kbuild-all@01.org Subject: [PATCH] clk: zynqmp: fix itnull.cocci warnings Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Iterator variable bound on line 220 cannot be NULL Generated by: scripts/coccinelle/iterators/itnull.cocci CC: Shubhrajyoti Datta Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu --- tree: https://github.com/Xilinx/linux-xlnx master head: 1741e191412444e3ab3308b407a9328186c248e4 commit: 75b49bd76a45208749235a7ba35dba96e3e706f0 [358/384] clk: zynqmp: Add check for no of users for vpll Actually, the patch needs to be extended to drop the braces as well. clk.c | 2 -- 1 file changed, 2 deletions(-) --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -218,8 +218,6 @@ static void clk_show_subtree(struct clk_ sibling++; hlist_for_each_entry(child, &c->children, child_node) { - if (!child) - return; clk_show_subtree(child, level + 1); } }