From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751473AbdBXUqi (ORCPT <rfc822;w@1wt.eu>);
        Fri, 24 Feb 2017 15:46:38 -0500
Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:44323
        "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751219AbdBXUqb (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 24 Feb 2017 15:46:31 -0500
X-IronPort-AV: E=Sophos;i="5.35,201,1484002800"; 
   d="scan'208";a="214643437"
Date: Fri, 24 Feb 2017 21:46:07 +0100 (CET)
From: Julia Lawall <julia.lawall@lip6.fr>
X-X-Sender: jll@hadrien
To: SIMRAN SINGHAL <singhalsimran0@gmail.com>
cc: outreachy-kernel <outreachy-kernel@googlegroups.com>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [Outreachy kernel] Re: [PATCH v2 3/3] staging: rtl8192u: Prefer
 using the BIT macro
In-Reply-To: <e1cde734-003d-4b3d-bba0-d37f5edd8e2b@googlegroups.com>
Message-ID: <alpine.DEB.2.20.1702242145060.2152@hadrien>
References: <20170217175059.GA26957@singhal-Inspiron-5558> <20170224171613.GA376@kroah.com> <e1cde734-003d-4b3d-bba0-d37f5edd8e2b@googlegroups.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-2027297004-1487969178=:2152"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--8323329-2027297004-1487969178=:2152
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT



On Fri, 24 Feb 2017, SIMRAN SINGHAL wrote:

>
>
> On Friday, February 24, 2017 at 10:46:21 PM UTC+5:30, gregkh wrote:
>       On Fri, Feb 17, 2017 at 11:20:59PM +0530, simran singhal wrote:
>       > Replaces left shift operation (1 << d) by BIT(x) macro.
>       >
>       > Fix the checkpatch.pl issue:
>       > CHECK: Prefer using the BIT macro replacing
>       >
>       > Signed-off-by: simran singhal <singhal...@gmail.com>
>       > ---
>       >  
>       >  V2:
>       >    -modified patch message.
>       >
>       >  drivers/staging/rtl8192u/ieee80211/ieee80211.h | 140
>       ++++++++++++-------------
>       >  1 file changed, 70 insertions(+), 70 deletions(-)
>
>       The last chunk of this patch did not apply, please fix up and
>       resend.
>
>       thanks,
>
>       greg k-h
>
>
>   Can you please elaborate what's the problem with the last chunk of this
> patch and 
>   to be more precise what do you mean by "last chunk of this patch". I am
> not getting 
>   what's the problem with this patch.

I would say "hunk" rather than "chunk", but he probably means the code
from the last @@ @@ to the end.

The best thing is to just pull the most recent version of the kernel and
see what happens when you try to apply your patch.

julia
--8323329-2027297004-1487969178=:2152--