From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751720AbdBYGbj (ORCPT ); Sat, 25 Feb 2017 01:31:39 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:17180 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751690AbdBYGbh (ORCPT ); Sat, 25 Feb 2017 01:31:37 -0500 X-IronPort-AV: E=Sophos;i="5.35,202,1484002800"; d="scan'208";a="262024706" Date: Sat, 25 Feb 2017 07:31:10 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Arushi Singhal cc: arnaud.patard@rtp-net.org, Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH v2] staging: xgifb: correct the multiple line dereference In-Reply-To: <20170224234130.GA608@arushi-HP-Pavilion-Notebook> Message-ID: References: <20170224234130.GA608@arushi-HP-Pavilion-Notebook> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 25 Feb 2017, Arushi Singhal wrote: > Error was reported by checkpatch.pl as > WARNING: Avoid multiple line dereference... > And If there is boolean operator then it is fixed by Splitting line at > boolean operator.This is a coding style error. There is strange spacing and capitalization in the above two lines. Only the first word in a sentence should be capitalized. There should be at least one space after a period. > The changes are made such that the other errors does not generate > beacause of this change like line exceeding 80 characters length. This doesn't say anything about what you did. > Signed-off-by: Arushi Singhal > --- > changes in v2 > - changes done such that no other errors can generate. > --- You don't need --- here. Only the one just below the Signed off by. julia > drivers/staging/xgifb/XGI_main_26.c | 21 +++++++++------------ > drivers/staging/xgifb/vb_setmode.c | 14 +++++++------- > 2 files changed, 16 insertions(+), 19 deletions(-) > > diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c > index 6930f7eb741b..651987398d42 100644 > --- a/drivers/staging/xgifb/XGI_main_26.c > +++ b/drivers/staging/xgifb/XGI_main_26.c > @@ -878,30 +878,27 @@ static void XGIfb_post_setmode(struct xgifb_video_info *xgifb_info) > } > > if ((filter >= 0) && (filter <= 7)) { > + const u8 *f = XGI_TV_filter[filter_tb].filter[filter]; > + > pr_debug("FilterTable[%d]-%d: %*ph\n", > filter_tb, filter, > - 4, XGI_TV_filter[filter_tb]. > - filter[filter]); > + 4, f); > xgifb_reg_set( > XGIPART2, > 0x35, > - (XGI_TV_filter[filter_tb]. > - filter[filter][0])); > - xgifb_reg_set( > + (f[0])); > + xgifb_reg_set( > XGIPART2, > 0x36, > - (XGI_TV_filter[filter_tb]. > - filter[filter][1])); > - xgifb_reg_set( > + (f[1])); > + xgifb_reg_set( > XGIPART2, > 0x37, > - (XGI_TV_filter[filter_tb]. > - filter[filter][2])); > + (f[2])); > xgifb_reg_set( > XGIPART2, > 0x38, > - (XGI_TV_filter[filter_tb]. > - filter[filter][3])); > + (f[3])); > } > } > } > diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c > index 7c7c8c8f1df3..1220d0cea87d 100644 > --- a/drivers/staging/xgifb/vb_setmode.c > +++ b/drivers/staging/xgifb/vb_setmode.c > @@ -221,8 +221,8 @@ static unsigned char XGI_AjustCRT2Rate(unsigned short ModeIdIndex, > > for (; XGI330_RefIndex[RefreshRateTableIndex + (*i)].ModeID == > tempbx; (*i)--) { > - infoflag = XGI330_RefIndex[RefreshRateTableIndex + (*i)]. > - Ext_InfoFlag; > + infoflag = > + XGI330_RefIndex[RefreshRateTableIndex + (*i)].Ext_InfoFlag; > if (infoflag & tempax) > return 1; > > @@ -231,8 +231,8 @@ static unsigned char XGI_AjustCRT2Rate(unsigned short ModeIdIndex, > } > > for ((*i) = 0;; (*i)++) { > - infoflag = XGI330_RefIndex[RefreshRateTableIndex + (*i)]. > - Ext_InfoFlag; > + infoflag = > + XGI330_RefIndex[RefreshRateTableIndex + (*i)].Ext_InfoFlag; > if (XGI330_RefIndex[RefreshRateTableIndex + (*i)].ModeID > != tempbx) { > return 0; > @@ -5092,8 +5092,8 @@ unsigned short XGI_GetRatePtrCRT2(struct xgi_hw_device_info *pXGIHWDE, > > i = 0; > do { > - if (XGI330_RefIndex[RefreshRateTableIndex + i]. > - ModeID != ModeNo) > + if (XGI330_RefIndex[RefreshRateTableIndex + i].ModeID > + != ModeNo) > break; > temp = XGI330_RefIndex[RefreshRateTableIndex + i].Ext_InfoFlag; > temp &= ModeTypeMask; > @@ -5484,7 +5484,7 @@ unsigned char XGISetModeNew(struct xgifb_video_info *xgifb_info, > return 0; > > pVBInfo->ModeType = XGI330_EModeIDTable[ModeIdIndex]. > - Ext_ModeFlag & ModeTypeMask; > + Ext_ModeFlag & ModeTypeMask; > > pVBInfo->SetFlag = 0; > pVBInfo->VBInfo = DisableCRT2Display; > -- > 2.11.0 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170224234130.GA608%40arushi-HP-Pavilion-Notebook. > For more options, visit https://groups.google.com/d/optout. >