From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751853AbdBYNUx (ORCPT ); Sat, 25 Feb 2017 08:20:53 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:30384 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751284AbdBYNUw (ORCPT ); Sat, 25 Feb 2017 08:20:52 -0500 X-IronPort-AV: E=Sophos;i="5.35,203,1484002800"; d="scan'208";a="214691923" Date: Sat, 25 Feb 2017 14:20:48 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Anda-Alexandra Dorneanu cc: perex@perex.cz, tiwai@suse.com, lgirdwood@gmail.com, broonie@kernel.org, Julia.Lawall@lip6.fr, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: kirkwood: Add a blank line after declarations In-Reply-To: <1488020203-14025-1-git-send-email-andadrn@gmail.com> Message-ID: References: <1488020203-14025-1-git-send-email-andadrn@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 25 Feb 2017, Anda-Alexandra Dorneanu wrote: > From: andadrn Drop the From line. The From line needs to match up with your Signed off by line. But the one generated by your mailer already does that, while the one you added does not. julia > > This was reported by checkpatch.pl > > Signed-off-by: Anda-Alexandra Dorneanu > --- > sound/soc/kirkwood/kirkwood-dma.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/soc/kirkwood/kirkwood-dma.c b/sound/soc/kirkwood/kirkwood-dma.c > index dafd22e..0af5d46 100644 > --- a/sound/soc/kirkwood/kirkwood-dma.c > +++ b/sound/soc/kirkwood/kirkwood-dma.c > @@ -24,6 +24,7 @@ > static struct kirkwood_dma_data *kirkwood_priv(struct snd_pcm_substream *subs) > { > struct snd_soc_pcm_runtime *soc_runtime = subs->private_data; > + > return snd_soc_dai_get_drvdata(soc_runtime->cpu_dai); > } > > @@ -91,6 +92,7 @@ static irqreturn_t kirkwood_dma_irq(int irq, void *dev_id) > /* try to find matching cs for current dma address */ > for (i = 0; i < dram->num_cs; i++) { > const struct mbus_dram_window *cs = dram->cs + i; > + > if ((cs->base & 0xffff0000) < (dma & 0xffff0000)) { > writel(cs->base & 0xffff0000, > base + KIRKWOOD_AUDIO_WIN_BASE_REG(win)); > -- > 1.9.1 > >