From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751986AbdBYS5G (ORCPT ); Sat, 25 Feb 2017 13:57:06 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:60623 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751549AbdBYS5F (ORCPT ); Sat, 25 Feb 2017 13:57:05 -0500 X-IronPort-AV: E=Sophos;i="5.35,203,1484002800"; d="scan'208";a="214707582" Date: Sat, 25 Feb 2017 19:57:01 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Codrut Grosu cc: perex@perex.cz, tiwai@suse.com, lgirdwood@gmail.com, broonie@kernel.org, swarren@wwwdotorg.org, thierry.reding@gmail.com, gnurou@gmail.com, Julia.Lawall@lip6.fr, nicoleotsuka@gmail.com, alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: tegra: Remove unnecessary 'Block comments should align the * on each line' message In-Reply-To: <1488048686-5964-1-git-send-email-codrut.cristian.grosu@gmail.com> Message-ID: References: <1488048686-5964-1-git-send-email-codrut.cristian.grosu@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The subject line is not very accurate. You don't remove the message, in the sense of picking it up and putting it somewhere else. You adjust the code in some way such that the error no longer occurs. So it would be better to say what adjustment you have done. Something like line up *s in block comments. julia On Sat, 25 Feb 2017, Codrut Grosu wrote: > This was reported by checkpatch.pl > > Signed-off-by: Codrut Grosu > --- > sound/soc/tegra/tegra_alc5632.c | 2 +- > sound/soc/tegra/tegra_rt5640.c | 2 +- > sound/soc/tegra/tegra_rt5677.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/sound/soc/tegra/tegra_alc5632.c b/sound/soc/tegra/tegra_alc5632.c > index 0509902..1f648f9 100644 > --- a/sound/soc/tegra/tegra_alc5632.c > +++ b/sound/soc/tegra/tegra_alc5632.c > @@ -1,5 +1,5 @@ > /* > -* tegra_alc5632.c -- Toshiba AC100(PAZ00) machine ASoC driver > + * tegra_alc5632.c -- Toshiba AC100(PAZ00) machine ASoC driver > * > * Copyright (C) 2011 The AC100 Kernel Team > * Copyright (C) 2012 - NVIDIA, Inc. > diff --git a/sound/soc/tegra/tegra_rt5640.c b/sound/soc/tegra/tegra_rt5640.c > index 93a3568..cf706d0 100644 > --- a/sound/soc/tegra/tegra_rt5640.c > +++ b/sound/soc/tegra/tegra_rt5640.c > @@ -1,5 +1,5 @@ > /* > -* tegra_rt5640.c - Tegra machine ASoC driver for boards using RT5640 codec. > + * tegra_rt5640.c - Tegra machine ASoC driver for boards using RT5640 codec. > * > * Copyright (c) 2013, NVIDIA CORPORATION. All rights reserved. > * > diff --git a/sound/soc/tegra/tegra_rt5677.c b/sound/soc/tegra/tegra_rt5677.c > index ebf58d0..0ed2eca 100644 > --- a/sound/soc/tegra/tegra_rt5677.c > +++ b/sound/soc/tegra/tegra_rt5677.c > @@ -1,5 +1,5 @@ > /* > -* tegra_rt5677.c - Tegra machine ASoC driver for boards using RT5677 codec. > + * tegra_rt5677.c - Tegra machine ASoC driver for boards using RT5677 codec. > * > * Copyright (c) 2014, The Chromium OS Authors. All rights reserved. > * > 1.9.1 > >