From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751679AbdB0V17 (ORCPT ); Mon, 27 Feb 2017 16:27:59 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:34019 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751648AbdB0V1z (ORCPT ); Mon, 27 Feb 2017 16:27:55 -0500 X-IronPort-AV: E=Sophos;i="5.35,215,1484002800"; d="scan'208";a="262318148" Date: Mon, 27 Feb 2017 22:25:23 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: simran singhal cc: gregkh@linuxfoundation.org, lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH 2/5] staging: rtl8192u: Remove unnecessary else after return In-Reply-To: <1488219268-3006-2-git-send-email-singhalsimran0@gmail.com> Message-ID: References: <1488219268-3006-1-git-send-email-singhalsimran0@gmail.com> <1488219268-3006-2-git-send-email-singhalsimran0@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Feb 2017, simran singhal wrote: > This patch fixes the checkpatch warning that else is not generally > useful after a break or return. > > This was done using Coccinelle: > > @@ > expression e2; > statement s1; > @@ > if(e2) { ... return ...; } > -else > s1 > > Signed-off-by: simran singhal > --- > drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c > index 2453413..4d6c928 100644 > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c > @@ -374,8 +374,7 @@ static int ieee80211_tkip_encrypt(struct sk_buff *skb, int hdr_len, void *priv) > > if (!tcb_desc->bHwSec) > return ret; > - else > - return 0; > + return 0; In contrast to another patch I commented on, it seems likely that here 0 means success. Converting 0 to false when that is what it means (ie not here) makes the code more understandable. julia