From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752802AbdCAKeu (ORCPT ); Wed, 1 Mar 2017 05:34:50 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:38874 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752411AbdCAKeo (ORCPT ); Wed, 1 Mar 2017 05:34:44 -0500 Date: Wed, 1 Mar 2017 11:00:43 +0100 (CET) From: Thomas Gleixner To: Arun Raghavan cc: linux-kernel@vger.kernel.org Subject: Re: [RESEND 2] [PATCH] rlimits: Print more information when limits are exceeded In-Reply-To: <20170218083750.12305-1-arun@arunraghavan.net> Message-ID: References: <20170218083750.12305-1-arun@arunraghavan.net> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 18 Feb 2017, Arun Raghavan wrote: > This dumps some information in logs when a process exceeds its CPU or RT > limits (soft and hard). Makes debugging easier when userspace triggers > these limits. Sigh. This changelog sucks. "dumps some information" is pretty useless and it does not explain WHY you want to do that. Please structure the changelog in a way which makes it easy to understand. 1) Problem description 2) Solution > diff --git a/kernel/time/posix-cpu-timers.c b/kernel/time/posix-cpu-timers.c > index e9e8c10..6dbcf84 100644 > --- a/kernel/time/posix-cpu-timers.c > +++ b/kernel/time/posix-cpu-timers.c > @@ -860,6 +860,9 @@ static void check_thread_timers(struct task_struct *tsk, > * At the hard limit, we just die. > * No need to calculate anything else now. > */ > + printk(KERN_INFO pr_info("CPU Watchdog Timeout (hard): %s[%d]\n", and no artificial line breaks, please. Thanks, tglx