From: Julia Lawall <julia.lawall@lip6.fr>
To: SIMRAN SINGHAL <singhalsimran0@gmail.com>
Cc: Joe Perches <joe@perches.com>,
Larry.Finger@lwfinger.net,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg KH <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
oleg.drokin@intel.com, marvin24@gmx.de,
outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] Re: [PATCH v3 0/5] Fixed compilation error
Date: Fri, 3 Mar 2017 17:15:59 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1703031714430.3490@hadrien> (raw)
In-Reply-To: <CALrZqyMKJvhQMAdjtLWWKTtxOP+icRZ6bctB0bTtzA8gJi+wNA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2394 bytes --]
On Fri, 3 Mar 2017, SIMRAN SINGHAL wrote:
> On Fri, Mar 3, 2017 at 9:20 PM, Joe Perches <joe@perches.com> wrote:
> > On Fri, 2017-03-03 at 17:05 +0530, simran singhal wrote:
> >> Fixed compilation warning in lustre/lustre/llite/range_lock.c
> >
> > Really? What compilation warning was removed?
>
> CC [M] drivers/staging/lustre/lustre/mgc/mgc_request.o
> drivers/staging/lustre/lustre/mgc/mgc_request.c: In function
> ‘mgc_set_info_async’:
> drivers/staging/lustre/lustre/mgc/mgc_request.c:1036:115: warning:
> format ‘%s’ expects argument of type ‘char *’, but argument 3 has type
> ‘void *’ [-Wformat=]
>
> I was getting this warning because of changing (char *)val to val
> where val is a pointer to void.
> So I fixed this by reverting this change.
Someone pointed out recently that when you make the cover letter for vn+1,
the subject should not change. It doesn't describe what is new in the
version. You put that in the message.
julia
>
> Simran
>
> >
> >> simran singhal (5):
> >> staging: nvec: Remove unnecessary cast on void pointer
> >> staging: lustre: Remove unnecessary cast on void pointer
> >> staging: lustre: lustre: Remove unnecessary cast on void pointer
> >> staging: rts5208: Remove unnecessary cast on void pointer
> >> staging: rtl8712: Remove unnecessary cast on void pointer
> >
> > What compiler warns about unnecessary casts?
> >
> >> drivers/staging/lustre/lustre/llite/range_lock.c | 2 +-
> >> drivers/staging/lustre/lustre/lmv/lmv_obd.c | 4 ++--
> >> drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +-
> >> drivers/staging/nvec/nvec_kbd.c | 2 +-
> >> drivers/staging/rtl8712/rtl8712_recv.c | 11 +++++------
> >> drivers/staging/rts5208/rtsx_transport.c | 3 +--
> >> 6 files changed, 11 insertions(+), 13 deletions(-)
> >>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CALrZqyMKJvhQMAdjtLWWKTtxOP%2BicRZ6bctB0bTtzA8gJi%2BwNA%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
next prev parent reply other threads:[~2017-03-03 16:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 11:35 simran singhal
2017-03-03 11:35 ` [PATCH v3 1/5] staging: nvec: Remove unnecessary cast on void pointer simran singhal
2017-03-03 11:35 ` [PATCH v3 2/5] staging: lustre: " simran singhal
2017-03-03 11:35 ` [PATCH v3 3/5] staging: lustre: " simran singhal
2017-03-03 11:35 ` [PATCH v3 4/5] staging: rts5208: " simran singhal
2017-03-03 11:35 ` [PATCH v3 5/5] staging: rtl8712: " simran singhal
2017-03-03 15:50 ` [PATCH v3 0/5] Fixed compilation error Joe Perches
2017-03-03 16:05 ` SIMRAN SINGHAL
2017-03-03 16:15 ` Julia Lawall [this message]
2017-03-03 16:37 ` [Outreachy kernel] " SIMRAN SINGHAL
2017-03-03 20:13 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1703031714430.3490@hadrien \
--to=julia.lawall@lip6.fr \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marvin24@gmx.de \
--cc=oleg.drokin@intel.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=singhalsimran0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®