From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752288AbdCCStx (ORCPT ); Fri, 3 Mar 2017 13:49:53 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:36392 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752486AbdCCStv (ORCPT ); Fri, 3 Mar 2017 13:49:51 -0500 X-IronPort-AV: E=Sophos;i="5.35,238,1484002800"; d="scan'208";a="215504461" Date: Fri, 3 Mar 2017 19:45:17 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Arushi Singhal cc: w.d.hubbs@gmail.com, chris@the-brannons.com, outreachy-kernel@googlegroups.com, kirk@reisers.ca, samuel.thibault@ens-lyon.org, gregkh@linuxfoundation.org, speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [Outreachy kernel] [PATCH 2/6] staging: speakup: simple_strtoul is replaced with kstrtoul In-Reply-To: <20170303183707.14830-3-arushisinghal19971997@gmail.com> Message-ID: References: <20170303183707.14830-1-arushisinghal19971997@gmail.com> <20170303183707.14830-3-arushisinghal19971997@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 4 Mar 2017, Arushi Singhal wrote: > This patch fixes "simple_strtoul is obsolete, use kstrtoul instead" > warning. > > Signed-off-by: Arushi Singhal > --- > drivers/staging/speakup/kobjects.c | 4 ++-- > drivers/staging/speakup/main.c | 2 +- > drivers/staging/speakup/varhandlers.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c > index edde9e68779e..a82698c66568 100644 > --- a/drivers/staging/speakup/kobjects.c > +++ b/drivers/staging/speakup/kobjects.c > @@ -152,7 +152,7 @@ static ssize_t chars_chartab_store(struct kobject *kobj, > continue; > } > > - index = simple_strtoul(cp, &temp, 10); > + index = kstrtoul(cp, &temp, 10); It seems unlikely that you actually compiled this code. The argument list for kstrtoul has a completely different set of types. julia > if (index > 255) { > rejected++; > cp = linefeed + 1; > @@ -785,7 +785,7 @@ static ssize_t message_store_helper(const char *buf, size_t count, > continue; > } > > - index = simple_strtoul(cp, &temp, 10); > + index = kstrtoul(cp, &temp, 10); > > while ((temp < linefeed) && (*temp == ' ' || *temp == '\t')) > temp++; > diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c > index 17df20ec94be..b43e2e156602 100644 > --- a/drivers/staging/speakup/main.c > +++ b/drivers/staging/speakup/main.c > @@ -1945,7 +1945,7 @@ static int handle_goto(struct vc_data *vc, u_char type, u_char ch, u_short key) > return 1; > } > > - goto_pos = simple_strtoul(goto_buf, &cp, 10); > + goto_pos = kstrtoul(goto_buf, &cp, 10); > > if (*cp == 'x') { > if (*goto_buf < '0') > diff --git a/drivers/staging/speakup/varhandlers.c b/drivers/staging/speakup/varhandlers.c > index cc984196020f..5107533bb45a 100644 > --- a/drivers/staging/speakup/varhandlers.c > +++ b/drivers/staging/speakup/varhandlers.c > @@ -325,7 +325,7 @@ char *spk_s2uchar(char *start, char *dest) > { > int val; > > - val = simple_strtoul(skip_spaces(start), &start, 10); > + val = kstrtoul(skip_spaces(start), &start, 10); > if (*start == ',') > start++; > *dest = (u_char)val; > -- > 2.11.0 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170303183707.14830-3-arushisinghal19971997%40gmail.com. > For more options, visit https://groups.google.com/d/optout. >