From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755046AbdCITLN (ORCPT <rfc822;w@1wt.eu>);
        Thu, 9 Mar 2017 14:11:13 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:52788 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754822AbdCITLM (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 9 Mar 2017 14:11:12 -0500
Date: Thu, 9 Mar 2017 20:11:03 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Mike Galbraith <efault@gmx.de>
cc: "Tobin C. Harding" <me@tobin.cc>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [regression] 72042a8c7b01 x86/purgatory: Make functions and
 variables static
In-Reply-To: <1489083766.5228.10.camel@gmx.de>
Message-ID: <alpine.DEB.2.20.1703092010340.3832@nanos>
References: <1489068254.4381.18.camel@gmx.de>  <alpine.DEB.2.20.1703091849400.3521@nanos> <1489083766.5228.10.camel@gmx.de>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 9 Mar 2017, Mike Galbraith wrote:
> On Thu, 2017-03-09 at 18:50 +0100, Thomas Gleixner wrote:
> > On Thu, 9 Mar 2017, Mike Galbraith wrote:
> > 
> > > Greetings,
> > > 
> > > I bisected kdump breakage to $subject, and verified the identified
> > > culprit via revert.  Seems kexec needs those variables as they were.
> > 
> > Yuck. That does not make any sense at all. I'll try to figure out why.
> 
> Dunno, but I did find this.
> 
> git@homer:..kexec-tools/kexec-tools-2.0.5> grep -IR 'elf_rel_.*symbol' . | egrep 'backup_|digest'|grep x86_64
> ./kexec/arch/x86_64/kexec-x86_64.c:     elf_rel_set_symbol(&info->rhdr, "backup_src_start",
> ./kexec/arch/x86_64/kexec-x86_64.c:     elf_rel_set_symbol(&info->rhdr, "backup_src_size",
> ./kexec/arch/x86_64/kexec-x86_64.c:             elf_rel_set_symbol(&info->rhdr, "backup_start",

Came so far as well. Lovely undocumented dependencies.....