From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753257AbdCIVg3 (ORCPT ); Thu, 9 Mar 2017 16:36:29 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:38037 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751067AbdCIVg2 (ORCPT ); Thu, 9 Mar 2017 16:36:28 -0500 X-IronPort-AV: E=Sophos;i="5.36,137,1486422000"; d="scan'208";a="216218250" Date: Thu, 9 Mar 2017 22:36:24 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Arushi Singhal cc: w.d.hubbs@gmail.com, chris@the-brannons.com, outreachy-kernel@googlegroups.com, kirk@reisers.ca, samuel.thibault@ens-lyon.org, gregkh@linuxfoundation.org, speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [Outreachy kernel] [PATCH 5/6] staging: speakup: Alignment should match open parenthesis In-Reply-To: <20170309190320.25681-6-arushisinghal19971997@gmail.com> Message-ID: References: <20170309190320.25681-1-arushisinghal19971997@gmail.com> <20170309190320.25681-6-arushisinghal19971997@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 10 Mar 2017, Arushi Singhal wrote: > Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". > > Signed-off-by: Arushi Singhal > --- > if (synth_request_region(speakup_info.port_tts - 1, > - SYNTH_IO_EXTENT)) { > + SYNTH_IO_EXTENT)) { > pr_warn("sorry, port already reserved\n"); > return -EBUSY; > } > @@ -270,7 +270,7 @@ static int synth_probe(struct spk_synth *synth) > } else { > for (i = 0; synth_portlist[i]; i++) { > if (synth_request_region(synth_portlist[i], > - SYNTH_IO_EXTENT)) { > + SYNTH_IO_EXTENT)) { These are not correct. SYNTH_IO_EXTENT should be lines up with the right side of the ( of the argument list of which it is an element. So the original code is either correct or close to correct. julia